Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct argument order of implode calls #857

Merged
merged 1 commit into from
Jan 21, 2020
Merged

correct argument order of implode calls #857

merged 1 commit into from
Jan 21, 2020

Conversation

Flyingmana
Copy link
Contributor

@Flyingmana Flyingmana commented Nov 23, 2019 •
edited
Loading

@Flyingmana
correct argument order of implode calls
7a01eb2 
reversed order is deprecated from php 7.4 on
@Flyingmana Flyingmana added this to the PHP 7.4 milestone Nov 23, 2019
@kkrieger85
Copy link
Contributor

As I understand rfc, in PHP 7.4 following happens to implode() calls:

implode( $pieces, $glue) => deprecation warning
implode( $glue, $pieces) => OK
implode ( $pieces ) => OK

kkrieger85
kkrieger85 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kkrieger85 kkrieger85 added the review needed Problem should be verified label Nov 25, 2019
@Flyingmana Flyingmana merged commit 8a99646 into OpenMage:1.9.4.x Jan 21, 2020
@sreichel sreichel added PHP 7.x Related to PHP 7.x Cleanup: Code style Related to simple CS fixes. and removed review needed Problem should be verified labels Jun 5, 2020
@sreichel sreichel modified the milestones: PHP 7.4, Release 19.4.1 Jun 27, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@Flyingmana @edannenberg
[bug-OpenMage#857] Fix implode() calls to work with PHP 7.4
b159f6e 
Reversed order is deprecated with PHP 7.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes. PHP 7.x Related to PHP 7.x
Projects
None yet
Milestone
Release 19.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Flyingmana @kkrieger85 @colinmollenhour @sreichel