Add missing methods to category collection class. #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
changed the title
Flyingmana
approved these changes
Jan 16, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
These two methods exist on Mage_Catalog_Model_Resource_Category_Flat_Collection but not on Mage_Catalog_Model_Resource_Category_Collection so if flat categories is enabled but they are being temporarily rebuilt and any frontend code relies on these methods, calls to these methods will generate PHP errors since the flat collection and eav collection classes expose a different set of methods on the public API.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
These two methods exist on Mage_Catalog_Model_Resource_Category_Flat_Collection but not on Mage_Catalog_Model_Resource_Category_Collection so if flat categories is enabled but they are being temporarily rebuilt and any frontend code relies on these methods, calls to these methods will generate PHP errors since the flat collection and eav collection classes expose a different set of methods on the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two methods exist on
Mage_Catalog_Model_Resource_Category_Flat_Collectionbut not onMage_Catalog_Model_Resource_Category_Collectionso if flat categories is enabled but they are being temporarily rebuilt and any frontend code relies on these methods, calls to these methods will generate PHP errors since the flat collection and eav collection classes expose a different set of methods on the public API.