Removed ES6 JS introduced in 1.9.4.4 for IE compability #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert and fixes 8 when merging 5d6d48b into 4f2c905 - view on LGTM.com new alerts:
fixed alerts:
|
colinmollenhour
previously approved these changes
Feb 4, 2020
spinsch
previously approved these changes
Feb 6, 2020
Flyingmana
suggested changes
Feb 6, 2020
There was a problem hiding this comment.
the lgtm check reports one new Syntax error https://github.com/OpenMage/magento-lts/pull/895/checks
seen here: https://lgtm.com/projects/g/OpenMage/magento-lts/rev/pr-d36a7c7b82b97f430b4318b298b67a3f2dc3fe01
When Trying out the changed function in the chrome console, it reports:
Uncaught SyntaxError: missing ) after argument list
Short: The closing brace for the forEach( is missing
samsteele
dismissed stale reviews from spinsch and colinmollenhour
via
41147e9
|
Added missing bracket |
Flyingmana
approved these changes
Feb 6, 2020
midlan
approved these changes
Feb 10, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…/js.js Not supported by IE
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
…/js.js Not supported by IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.