unused variable cleanup #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
approved these changes
Mar 9, 2020
Flyingmana
approved these changes
Mar 10, 2020
|
@Flyingmana @colinmollenhour @kkrieger85 @kpitn |
|
May be right. But in my view, it's a new bug/feature.
Am Di., 10. März 2020 um 09:23 Uhr schrieb henrykb <notifications@github.com
…:
@Flyingmana <https://github.com/Flyingmana> @colinmollenhour
<https://github.com/colinmollenhour> @kkrieger85
<https://github.com/kkrieger85> @kpitn <https://github.com/kpitn>
IMO there should be $cart->turncate(); or any advanced logic for this
because 'reorder' shouldn't contain current/past cart items
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#910?email_source=notifications&email_token=ABB24Q7743S37SLO2223ZV3RGX2GJA5CNFSM4LEIHVA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKOMPI#issuecomment-596960829>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB24Q3NP2JUD32JRW4LXR3RGX2GJANCNFSM4LEIHVAQ>
.
|
sreichel
added
Cleanup: Code style
Can you please create a new issue for this? |
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.