allow (json-)strings for Mage_HTTP_Client_Curl::makeRequest $params Parameter

[viable-hartman]

What does everybody think about adding this method to allow the Mage Curl client to do proper POSTs of JSON directly. I know of a few REST apis that require this.

This would allow doing this in code to POST json data directly:

$curl = new Mage_HTTP_Client_Curl();
$curl->post_json($url, $params);

[spinsch]

I have looked at the customized version of Magento 2 and discovered the following adaptation:

$this->curlOption(CURLOPT_POSTFIELDS, is_array($params) ? http_build_query($params) : $params);

This would solve your problem elegantly and offer the possibility of other types such as XML.

$uri = '';
$params = array();
$client = new Mage_HTTP_Client_Curl();

$client->addHeader('content-type', 'application/json');
$client->makeRequest('POST', $uri, json_encode($params));

[viable-hartman]

Oh yes, that is better, I'll change the request to make that change instead 👍

[viable-hartman]

Per @spinsch just submitted the Magento 2 fix for JSON POST utilized as he indicated:
Just one edit since makeRequest is protected calling post is necessary, but doesn't change the solution!

$uri = '';
$params = array();
$client = new Mage_HTTP_Client_Curl();

$client->addHeader('content-type', 'application/json');
$client->post($uri, json_encode($params));

Great idea to look at the Magento 2 repo first, should have thought of that :-) , and will in the future!

[tmotyl]

doc comment needs to be tuned array|string
But it's a very useful change, had similar challenge with magento EE recently too.

[viable-hartman]

doc comment needs to be tuned array|string
But it's a very useful change, had similar challenge with magento EE recently too.

Updated! 👍