Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change all ands in conditional statements to && for better consistency #970

Merged
merged 1 commit into from
May 14, 2020
Merged

change all ands in conditional statements to && for better consistency #970

merged 1 commit into from
May 14, 2020

Conversation

paulrodriguez
Copy link
Contributor

Issue #958
i removed AND operators in conditional statements and replaced them with && to improve consistency throughout the project.
I only changed files in the app/core folder.

@tmotyl tmotyl added the Cleanup: Code style Related to simple CS fixes. label May 13, 2020
sreichel
sreichel approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinmollenhour colinmollenhour merged commit c41043d into OpenMage:1.9.4.x May 14, 2020
@paulrodriguez paulrodriguez deleted the remove-and-in-condition branch May 15, 2020 04:26
@sreichel sreichel added this to the Release 19.4.4 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@kiatng kiatng kiatng approved these changes

@sreichel sreichel sreichel approved these changes

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes.
Projects
None yet
Milestone
Release 19.4.4 / 20.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@paulrodriguez @colinmollenhour @kiatng @sreichel @tmotyl