Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced join() with implode() #986

Closed
wants to merge 4 commits into from
Closed

Replaced join() with implode() #986

wants to merge 4 commits into from

Conversation

sreichel
Copy link
Contributor

Alias method ...

@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label May 19, 2020
kiatng
kiatng previously approved these changes May 19, 2020
View reviewed changes
@tmotyl
Copy link
Contributor

tmotyl commented May 19, 2020

please exclude whitespace changes (just join->implode) so it doesn't conflict with other cleanup changes

kkrieger85
kkrieger85 previously approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Better/Cleaner way: Seperate join/implode changes from code style changes

@sreichel sreichel added the hold label May 22, 2020
@sreichel sreichel dismissed stale reviews from kkrieger85 and kiatng via 8661e1a May 30, 2020 02:38
@sreichel sreichel marked this pull request as draft May 30, 2020 02:43
@kkrieger85
Copy link
Contributor

I don't understand the relation between 8661e1a and this ticket

@sreichel
Copy link
Contributor Author

I don't understand the relation between 8661e1a and this ticket

I have just resolved conflicts.

kkrieger85
kkrieger85 previously approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@sreichel
Copy link
Contributor Author

LGTM now

Cause of possible conflicts i'd leave it as draft for now, till doc changes are in ...

@sreichel sreichel modified the milestone: Release 19.4.7 Jun 26, 2020
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogSearch Relates to Mage_CatalogSearch labels Jul 24, 2020
@sreichel sreichel closed this Jan 13, 2021
@sreichel sreichel deleted the cs/join-vs-implode branch January 13, 2021 01:44
@sreichel sreichel removed the hold label Jan 13, 2021
@sreichel sreichel mentioned this pull request Jan 13, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrieger85 kkrieger85 kkrieger85 left review comments

@kiatng kiatng kiatng left review comments

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes. Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogSearch Relates to Mage_CatalogSearch invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @tmotyl @kkrieger85 @kiatng