Fix write past fixed size buffer #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #660 #1089
Maybe change weights in 01a119a 5155e3f
Essentially buffer[size] is accessed at buffer[size+1] in last loop. It is visible when build machine is same as run machine, distribution packages build with lots of spare thread slots and unlikely are affected.
It is not a fix, just it adds blank where otherwise nearby structure is corrupted to no gdb-recognition.
Probably there are others, I just scanned nearby lines with [x] and [y+1] and looked at [x]