Fix out-of-bounds memory accesses exposed by xccblat3 testcase #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In longer run they become non-zero, looping benchmarks down could expose similar blunders much better. |
|
I do not believe my "solution" anymore either, currently trying to find if/where/when a01 grows beyond a. |
|
This at least assists with most visible case. I am pretty sure non-zero is not expected from behind the array. |
|
My current thinking is that the "if" block that contains the potential bug serves no useful purpose at all. Even when it happens to address something within the source array the matching result appears to be obtained by another iteration of the main loop anyway. At least I have not managed to come up with a testcase where the problematic code is both executed at all and required for a correct result. |
...and does not appear to be needed even when it stays within the bounds of the array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601. As far as I can tell, the data in these locations should be zero in any case.