Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of AVX-512 C flags #1911

Closed
wants to merge 2 commits into from
Closed

Reduce scope of AVX-512 C flags #1911

wants to merge 2 commits into from

Conversation

brada4
Copy link
Contributor

@brada4 brada4 commented Dec 11, 2018

Should fix #1909
Not sure if it spots cygwin correctly still
Probably -march=skylake-avx512 can be replaced with -mavx512vl

@martin-frbg
Copy link
Collaborator

see #1910. Your idea of putting it into the FORCE_SKYLAKEX section is more elegant, but I expect it will indeed cause problems on Cygwin (mine is not perfect in this regard either, I guess I should copy the extra handling to the kernel Makefile)

@brada4
Copy link
Contributor Author

brada4 commented Dec 11, 2018

Each kernel type sort of deserves own -march flag (plus workarounds)
I dont see elegant way to put all in toplevel. Maybe -march=native if !DYNAMIC_ARCH !FORCE_TARGET ? What do you think?
EDIT: #1910 correctly keeps native SKYLAKEX build native with no impact on others.
I dont know what kicks old architectures will get from $FC -march=native , back then with gcc it was 10-20%, but not for numeric code.

@brada4
Copy link
Contributor Author

brada4 commented Dec 12, 2018

Testing alpine myself now.
Feel free to commit yours and I will adjust mine to fit over it.

@brada4
Copy link
Contributor Author

brada4 commented Dec 16, 2018

I will not be taking care of this until January, problem lies in build system compiling universal subarch codes with detected target flags, Same applies to arm(64), so there is a need for extra set of absolutely generic cflags for common code.

@brada4 brada4 closed this Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on circle-ci: f951: Error: bad value (skylake-avx512) for -march= switch
2 participants