Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix compilation on AIX #2682

Merged
merged 10 commits into from
Jul 13, 2020
Merged

[WIP] fix compilation on AIX #2682

merged 10 commits into from
Jul 13, 2020

Conversation

martin-frbg
Copy link
Collaborator

@martin-frbg martin-frbg commented Jun 25, 2020

Fixes several issues in conjunction with #2671 and #2694

  • TARGET autodetection always returning POWER5
  • Architecture detection failure setting the CROSS build flag
  • utest getting built as an empty shell without actual tests
  • lapack-test failures in COMPLEX with gfortran 7.3
  • inadequate compiler options for xlc/xlf
  • 32bit builds segfaulting in sgemm/dgemm/trsm (though this PR only drops 32bit-POWER8 to POWER6 for now)

@martin-frbg martin-frbg mentioned this pull request Jun 25, 2020
@trex58
Copy link

trex58 commented Jun 30, 2020

About c0afc11 (Fix POWERPC builds on AIX (gcc/gfortran 7)):

  • I see MYOS and MYTARGET instead of OS and TARGET (OK ! Fixed in c854ef5 !!!
  • Also, on AIX, we use the OpenSource GNU version of m4, not the AIX version. And, for the OpenSource GNU version (v1.4.18), the option -B does exist but is not documented (they say: " warning: `m4 -B' may be removed in a future release "). So, it should be better to use some variable which could be defined out of the Makefile.L3 file.

@martin-frbg
Copy link
Collaborator Author

I guess I could ask the m4 if it is GNU or AIX (probably not safe to assume everybody uses the GNU one). I have a few more compatibility fixes for assembly files that I need to append here, but I am still far from getting OpenBLAS to build with the AIX as and xlc (register naming, unimplemented constraints,...)

@martin-frbg martin-frbg merged commit 419b868 into OpenMathLib:develop Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants