Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win/arm64]: Explicit casting for GEMM_DEFAULT_ALIGN to create 64-bit value #3354

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

niyas-sait
Copy link
Contributor

Win64 uses the LLP64 data model and unsigned long is only 32-bit. For 64-bit architecture, we need a 64-bit mask to correctly generate the address.

…t value

Win64 uses LLP64 datamodel and unsigned long is only 32-bit. For 64-bit
architecture we need 64-bit mask to correctly generate address
@martin-frbg
Copy link
Collaborator

Probably safer to make this casting ifdef __WIN64 or something ? I had to throw out a lot of the earlier, generous sprinkling of casts (#3088) in the meantime as some compilers/preprocessors choked on it. (And I suspect now that all the (BLASLONG) added for x86 back then should have been BLASULONG as well ?)

@martin-frbg martin-frbg added this to the 0.3.18 milestone Aug 31, 2021
@niyas-sait
Copy link
Contributor Author

Probably safer to make this casting ifdef __WIN64 or something ? I had to throw out a lot of the earlier, generous sprinkling of casts (#3088) in the meantime as some compilers/preprocessors choked on it. (And I suspect now that all the (BLASLONG) added for x86 back then should have been BLASULONG as well ?)

Thanks, @martin-frbg. I have added a new commit to make it conditional on _WIN64 flag.

Yes using BLASULONG for x86 make sense to me. Do you want me to update it in this patch or shall i leave it for another PR ?

@martin-frbg
Copy link
Collaborator

Thank you.
As you prefer - I could also do this later (and remove any remaining casts from non-Win64 architectures)

@martin-frbg martin-frbg changed the title [win/arm64]: Explicit casting for GMEMM_DEFAULT_ALIGN to create 64-bit value [win/arm64]: Explicit casting for GEMM_DEFAULT_ALIGN to create 64-bit value Aug 31, 2021
@martin-frbg martin-frbg merged commit 47171e4 into OpenMathLib:develop Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants