Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPC970: fix scal #5048

Merged
merged 2 commits into from
Jan 4, 2025
Merged

PPC970: fix scal #5048

merged 2 commits into from
Jan 4, 2025

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Jan 4, 2025

@martin-frbg This seems to work for py-scipy. Does it look reasonable? Can I test it more specifically, besides scipy building?

Disclaimer: I cannot test this right now for Darwin ppc64, so that may be or not be broken. The fix is specific to Darwin ppc (32-bit ABI).

@barracuda156
Copy link
Contributor Author

P. S. I do not know what is NeoverseN1-OMP in CI, but it uses ARM flags, so arguable cannot be affected by a PowerPC-specific change.

@barracuda156
Copy link
Contributor Author

@martin-frbg I will do a clean rebuild from the tip of the develop now to confirm again this works.

@martin-frbg
Copy link
Collaborator

Thanks, looks convincing enough for me. The failed CI job happened to be dropped by the cloud provider shortly before completion and should reschedule soon

@martin-frbg martin-frbg added this to the 0.3.29 milestone Jan 4, 2025
@barracuda156
Copy link
Contributor Author

@martin-frbg A bit on a side note, is it possible to add a CI for Linux ppc32 (or FreeBSD / OpenBSD /NetBSD)? Would be useful, IMO.

@martin-frbg
Copy link
Collaborator

I can look into this, but it would certainly have to be emulated by qemu

@barracuda156
Copy link
Contributor Author

py312-scipy build works normally with OpenBLAS from 6f9b9e2 plus my commits from this PR, so I think this is good to go. May not be perfect, but apparently fixes the immediate problem.

@martin-frbg martin-frbg merged commit 91d861a into OpenMathLib:develop Jan 4, 2025
81 of 84 checks passed
@barracuda156 barracuda156 deleted the powerpc branch January 4, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression on PPC970, resulting in [some] dependents of OpenBLAS being unusable
2 participants