-
Notifications
You must be signed in to change notification settings - Fork 1
chore(pre-commit): line-count 500/750; warn on issue refs #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sugan0tech, while I appreciate the changes, I also think we're creating more resistance for the open source contributors with all these rules. What's your opinion? |
Agreed with your concerns, if we start to maintain these hygenes from the start will be feastable. and for the external contributors we have to consider them as black blox, for a genuine contributors these are the typical standards has to be followed. As with my previous experience each oss tools comes with their own set of guidelines integration multiple platform. Where as ours is all in github that's a advantage. But these remains a mandatory requiremet. Also that's why i had it as warning to a extent then it's an error for the file size case. |
|
If required i can make the commit issue reference can be a warning instead of a commit blocker. And with my recent talke with @venkatsp17 the EOF file validator is quite annoying, need to to make it auto apply at commit instead of doing a redo. |
|
Yeah, It must be auto-fixed in code editor instead of Pass check @sugan0tech. |
|
Apart from that I appreciate adding issue number with comment is to be mandatory and not case sensitive, Because I feel it would easy to track out commits when application scales. |
|
@sugan0tech, I agree with you, automating fixes for these checks instead of showing warnings/errors to the user is the right approach. If this is the case, I'm not as concerned as before. Good work guys. 👏 |
|
Irunga da dai, Github paduchutu varan onumea purla 😭 |
if LGTM naah approve please. |
…Warn above 500 lines; error above 750 lines.\n- Downgrade missing issue reference from error to warning.\n- Make exemptions (merge/revert/release bump) case-insensitive.\n\nRefs #34
|
Sorry for the delay, I'll approve the changes. |
|
It's up to @venkatsp17 and @aslamcodes. Guys, please review and approve. |
This PR updates pre-commit policies for file size and commit message issue references.
Changes
#<num>is present.Files
Rationale
Refs #34