Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian Translation for Tutorial 01 #3056

Merged
merged 11 commits into from
Feb 22, 2020
Merged

Italian Translation for Tutorial 01 #3056

merged 11 commits into from
Feb 22, 2020

Conversation

DanyEle
Copy link
Contributor

@DanyEle DanyEle commented Feb 15, 2020

Added basic Italian translation for Tutorial 01 with some text from Andrea Provino's blog.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@DanyEle
Copy link
Contributor Author

DanyEle commented Feb 20, 2020

@karlhigley Any idea why so many checks are failing? All I did was adding one more file without modifying any existing files.

@karlhigley
Copy link
Contributor

@DanyEle The test that's failing is test_github_workflows_exist_for_all_languages, which checks that each language has a GH workflow that runs the translated notebooks for that language when they change. You can find an example workflow file here.

@karlhigley
Copy link
Contributor

@DanyEle Testing out a change to the CI jobs that will bypass the workflow file requirement.

@DanyEle
Copy link
Contributor Author

DanyEle commented Feb 22, 2020

Already looks better. Now only the tutorials test for build 3.7 are failing with the following error:

Test with pytest:

##[error]Process completed with exit code 128.
Run git diff --name-only master examples/tutorials/translations/ > ./test/notebooks/git-diff.txt
fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
##[error]Process completed with exit code 128.

@karlhigley
Copy link
Contributor

@arturomf94 is working on this. We'll get it merged, one way or another.

@DanyEle
Copy link
Contributor Author

DanyEle commented Feb 22, 2020

Looks alright now! All checks passing.

@nph4rd
Copy link
Member

nph4rd commented Feb 22, 2020

@DanyEle looks like it passed, but for the wrong reasons. What were trying to do is to test only the notebooks that have been changed during the build. You can have a look at the changes here #3085 hopefully everything will run ok with that.

@karlhigley
Copy link
Contributor

@DanyEle We finally got the translation tests running correctly, so I'll merge this when the tests pass.

@karlhigley karlhigley merged commit c4d9fbc into OpenMined:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants