Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ux] fix tqdm prints multiple lines when client.upload_dataset #8894

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

khoaguin
Copy link
Member

@khoaguin khoaguin commented Jun 10, 2024

Issue: https://github.com/OpenMined/Heartbeat/issues/1274

If the dataset contains multiple assets, tqdm prints multiple lines:
Screenshot from 2024-06-10 09-31-19

The fix makes it only one line:
a

Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! ✅

@shubham3121 shubham3121 merged commit 28822a9 into OpenMined:dev Jun 10, 2024
23 checks passed
@khoaguin khoaguin deleted the fix-multiple-lines-tqdm branch June 11, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants