Added test to notebook for password token expiry #9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
snwagh
changed the title
snwagh
changed the title
….com:OpenMined/PySyft into snwagh/adding-test-for-password-token-expiry
| # expiry_time = settings.pwd_token_config.token_exp_min | ||
|
|
||
| # Option 2 | ||
| settings_service = context.server.get_service("settingsservice") |
There was a problem hiding this comment.
should we update to the context.server.services approach and remove the rest of this comment?
There was a problem hiding this comment.
Good point, will merge it with Teo's PR. Will wait for that to be merged so as to not create conflicts for his PR.
BrendanSchell
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test to check password token expiry.
Closes https://github.com/OpenMined/Heartbeat/issues/1808
Repurposed variable
token_exp_minto encode seconds.