Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving helpers into a better location #9288

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Moving helpers into a better location #9288

merged 7 commits into from
Sep 12, 2024

Conversation

BrendanSchell
Copy link
Contributor

@BrendanSchell BrendanSchell commented Sep 12, 2024

This changes the structure of notebook helpers.

  • from syft import get_helpers will provide you access to all helpers in notebooks/notebook_helpers (so no more path manipulation)
  • This import has to be done before third party import but isort will flip the order so add isort:on, off in your notebook cell with imports

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@snwagh snwagh changed the title [WIP] Scenario sync v2 Moving helpers into a better location Sep 12, 2024
@snwagh snwagh marked this pull request as ready for review September 12, 2024 19:42
Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks incredible!

@snwagh snwagh merged commit 4ad090c into dev Sep 12, 2024
38 checks passed
@snwagh snwagh deleted the scenario-sync-v2 branch September 12, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants