Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multithreading for BFV and CKKS sum inplace #393

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

vdasu
Copy link
Contributor

@vdasu vdasu commented Apr 27, 2022

Description

Closes #242 and #243.

Additional Changes:

  1. Added C++ tests for CKKSVector::sum_inplace as they were missing.
  2. I was facing import file mismatch errors with pytest as test_regression.py is present in TenSEAL/tests/python/sealapi/test_regression.py and TenSEAL/tests/python/tenseal/tensors/test_regression.py. Adding __init__.py in TenSEAL/tests/python/sealapi/ resolved this issue.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

C++ and Python tests have passed successfully.

Checklist

@bcebere
Copy link
Member

bcebere commented Apr 29, 2022

Thank you for your contribution! LGTM!

@bcebere bcebere merged commit ff1793f into OpenMined:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BFVVector: use multithreading for sum_inplace
2 participants