Users & Roles #35
Merged
Users & Roles #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHericles
added
the
Type: New Feature ➕
ariannmichael
approved these changes
Feb 25, 2021
tcp
reviewed
Feb 26, 2021
| canManageInfrastructure, | ||
| canUploadData | ||
| }) => { | ||
| const permissions = [ |
There was a problem hiding this comment.
Extract permissions out of the component. Maybe this could be in a JSON somewhere?
tcp
requested changes
Feb 26, 2021
src/pages/users/index.tsx
Outdated
| const {data: groupsData} = useQuery<Record<string, IGroup>, Error>('groups', fetchGroups) | ||
| const {data: rolesData} = useQuery<Record<string, IRole>, Error>('roles', fetchRoles) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I failed to see why we need to keep states to track the total. Is it possible to replace this effect with a direct call to each of the deps?
tcp
reviewed
Feb 26, 2021
src/pages/users/index.tsx
Outdated
| ))} | ||
| </section> | ||
| <section className="space-y-6"> | ||
| {Object.keys(usersData).map(userId => ( |
There was a problem hiding this comment.
usersData is undefined by default and will remain undefined if fetching fails.isLoading will resolve to false and Object.keys(undefined) throws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add users overview + list and roles page.
Add API Integration + Object and Response Types support
Issues
#22 #15
Affected Dependencies
Checklist