Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensors #59

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Tensors #59

merged 3 commits into from
Apr 1, 2021

Conversation

0xHericles
Copy link
Member

Description

  • List tensors
  • Delete Tensors
  • List Requests
  • View Request Reason
  • Accept/Deny requests

Linked Issues:

#44 #45 #46 #47 #48

TODO

  • Add confirmation dialogs
  • Add Links for navigation

@0xHericles 0xHericles requested a review from tcp March 15, 2021 13:27
@0xHericles 0xHericles changed the base branch from master to dev March 15, 2021 13:27
Copy link
Collaborator

@tcp tcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts. I'll resume the review afterwards.

src/pages/datasets/requests.tsx Outdated Show resolved Hide resolved
}
]
const {isLoading, data: requests, error} = useQuery<IRequest[], Error>('requests', fetchRequests)
const {data: datasetsData} = useQuery<IDataset[], Error>('datasets', fetchDatasets)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you fetch datasets here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need them to find the dataset name.

<PermissionRequestCard
  {...permission}
  tensors={'data.target'}
  {/*here*/}
  dataset={datasetsData.find(x => x.id === permission.objectId).name}
  retrieving={'requesting tensor'}
  key={`permission-card-${permission.objectId}-${permission.userId}`}
  onClickAccept={() => acceptRequest(permission.id.toString())}
  onClickReject={() => denyRequest(permission.id.toString())}
/>

@@ -0,0 +1,40 @@
import axios from '@/utils/api-axios'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these functions throw.

@tcp tcp added the Status: In Progress 🌟 This is actively being worked on label Mar 21, 2021
@tcp tcp added this to the v1.0.0 milestone Mar 21, 2021
@tcp tcp merged commit f5e8f93 into dev Apr 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/tensors branch April 1, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress 🌟 This is actively being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants