-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensors #59
Tensors #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve conflicts. I'll resume the review afterwards.
} | ||
] | ||
const {isLoading, data: requests, error} = useQuery<IRequest[], Error>('requests', fetchRequests) | ||
const {data: datasetsData} = useQuery<IDataset[], Error>('datasets', fetchDatasets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you fetch datasets here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need them to find the dataset name.
<PermissionRequestCard
{...permission}
tensors={'data.target'}
{/*here*/}
dataset={datasetsData.find(x => x.id === permission.objectId).name}
retrieving={'requesting tensor'}
key={`permission-card-${permission.objectId}-${permission.userId}`}
onClickAccept={() => acceptRequest(permission.id.toString())}
onClickReject={() => denyRequest(permission.id.toString())}
/>
@@ -0,0 +1,40 @@ | |||
import axios from '@/utils/api-axios' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of these functions throw.
Description
Linked Issues:
#44 #45 #46 #47 #48
TODO