-
Notifications
You must be signed in to change notification settings - Fork 15
Closed
Labels
Description
Some abstract models within Interfaces/Reactions package should be declared as "partial", for instance:
- Interfaces.Reactions.Qui.mo which is similar to Interfaces.Reactions.Qur.mo
- Interfaces.Reactions.Basics.OneSubstrateReversible.mo which should be similar to Interfaces.Reactions.Basics.OneSubstrate.mo
While the above models have more variables than equations, some models are consistent in this regard such as:
- Interfaces.Reactions.Modifiers.TwoModifiers.mo which is not declared as partial. However the similar model Interfaces.Reactions.Modifiers.ThreeModifiers.mo is declared as a partial model (despite having identical number of equations and unknown)
In the sense that these models are employed as interfaces and not as stand-alone components, to achieve consistency, I think all models in this subpackage should be also made abstract.
p.s. I will usually keep an issue open at least for one month, in case any one would like to comment!
Reactions are currently unavailable