Icons

[AtiyahElsheikh]

Although we have a package for Icons:

• Most of the icons are embedded in components. Any implementation that likes to exploit the graphical annotations need to copy and paste the annotations rather than extending components

• Some Icons are now in MSL, e.g. Library. We can rather reuse such icons from MSL

p.s. Any modifications will be considered in the main branches only after 7th of July

[AtiyahElsheikh]

I have just realized that those semi-standard icons in BioChem is nicer than the corresponding ones in MSL. Thus, no need to replace those with MSL Icons.

[AtiyahElsheikh]

When opening the library with OMC1.17.0-dev.beta3, the Icons on the left bar are not shown. (However, I can see the Icons of MSL 4.0.0)

[AtiyahElsheikh]

Implementations of Icons package is subject to improvement:

• The implementation of Icons package extends the Library Icon. It is better to rather employ the Icons Package from MSL

• The Library Icon is, to my understanding from the code, is equivalent to the Modelica.Icons.Package. However, the interface looks nicer, so I am going to leave it.

• The implementation of Icons.Example looks nicer than Modelica.Icons.Example. It consists of a name annotation, that is not used throughout the library. It is declared as a partial package, while the naming conventions imply that this Icon is associated with one example rather than examples package. The reason could be because an example in Biochem library is usually modelled within a package. So I am going to leave it.

• The same arguments apply for Icons.UnitsPackage and Icons.Substances.Package (Both of them are missing in the master branch). I am not sure what is Icons.IconBase is useful for? .. So I am going to leave them.

[AtiyahElsheikh]

Going to make use of Modelica.Icons.InterfacesPackage and Modelica.Icons.ExamplesPackage since they don't really exist in Biochem.Icons

[AtiyahElsheikh]

I have opened this ticket regarding icons not shown in the libraries browser of OMEdit