Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ModelicaSystem.simulate #217

Open
lafrech opened this issue Jun 12, 2024 · 0 comments
Open

Rework ModelicaSystem.simulate #217

lafrech opened this issue Jun 12, 2024 · 0 comments
Assignees

Comments

@lafrech
Copy link

lafrech commented Jun 12, 2024

Follow-up to #214. See comments.

Popen should be fed a list of arguments, not a single string. The fix in #214 splits the string but

  • arguments should be split one step further ("-r path" -> ["-r", "path"]
  • it makes no sense to concatenate strings then split them, the arguments should be built as a list in the first place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants