Use logging in modelica system syntron #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, please rebase this on master so the external dll path commits are not included. |
syntron
force-pushed
the
use_logging_in_ModelicaSystem_syntron
branch
from
3e16a13
to
7916694
Compare
|
Rebased to master (as #226 is included now) |
adeas31
requested changes
Nov 11, 2024
OMPython/__init__.py
Outdated
| ## Show notification or warnings to the user when verbose=True OR if some error occurred i.e., not result | ||
| if verbose or not result: | ||
| print(self.requestApi('getErrorString')) | ||
| if not result: |
There was a problem hiding this comment.
Check for self._verbose flag here. loadLibrary raises some warnings and notifications that are good to know specially when verbose is set.
OMPython/__init__.py
Outdated
| if verbose: | ||
| print("| info | setParameters() failed : It is not possible to set the following signal " + "\"" + name + "\"" + ", It seems to be structural, final, protected or evaluated or has a non-constant binding, use sendExpression(setParameterValue("+ self.modelName + ", " + name + ", " + value + "), parsed=false)" + " and rebuild the model using buildModel() API") | ||
| if self._verbose: | ||
| logger.warning("setParameters() failed : It is not possible to set " + |
OMPython/__init__.py
Outdated
| if self._raiseerrors: | ||
| raise ModelicaSystemError("OM error: {}".format(errstr)) | ||
| else: | ||
| logger.warning(errstr) |
* this simplifies a lot of functions!
* class variable _raiseerrors * functions _check_error() & _raise_error()
syntron
force-pushed
the
use_logging_in_ModelicaSystem_syntron
branch
from
8d412f2
to
f23c7f6
Compare
|
@adeas31 update based on your comments |
adeas31
approved these changes
Nov 12, 2024
OMPython/__init__.py
Outdated
| loadMsg = self.getconn.sendExpression(loadFileExp) | ||
| ## Show notification or warnings to the user when verbose=True OR if some error occurred i.e., not result | ||
| if verbose or not loadMsg: | ||
| return print(self.getconn.sendExpression("getErrorString()")) | ||
| if not loadMsg: |
There was a problem hiding this comment.
Forgot to add check for self._verbose flag here.
There was a problem hiding this comment.
Done in an added commit; see below ...
|
@arun3688 can you please review and test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ModelicaSystem to use Exceptions / the python logging interface (see #227)
It is based on #226 due to the develop history; if needed it could be rebased or parts could be extracted