Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELM-441: Use Perf Filter default param if available #786

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

synqotik
Copy link
Contributor

@synqotik synqotik commented Jun 27, 2023

Performance Filter parameters and defaults are being converted correctly, however the filter query editor was not using the defaults if a specific value did not exist; this fixes that, see paramValueOrDefault.

Also reformatted the file to have 2 space indentation (current standard).

External References

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@synqotik synqotik merged commit 70f29d2 into release-9.x Jun 28, 2023
@synqotik synqotik deleted the jira/HELM-441-filter-query-param-conversion branch June 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants