Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm-415: Docs direct user to create a Custom Action when creating a Dashboard but this feature no longer exists in Grafana v9 #787

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Bonrob2
Copy link
Contributor

@Bonrob2 Bonrob2 commented Jun 28, 2023

Pull Request Check Sheet

  • Have you read and followed our Contribution Guidelines?
  • Have you made an issue in the OpenNMS issue tracker?
    If so, you should:
    1. update the title of this PR to be of the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the JIRA link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
  • Have you made a comment in that issue which points back to this PR?
  • Have you updated the JIRA link at the bottom of this comment to link to your issue?
  • If this is a new feature, is there documentation?
  • If this is a new feature or substantial change, are there tests that cover it?

Pull Request Process

One or more reviewers should be assigned to each PR.

If you know that a particular person is subject matter expert in the area your PR affects, feel free to assign one or more reviewers when you create this PR, otherwise reviewers will be assigned for you.

Once the reviewer(s) accept the PR and the branch passes continuous integration in Bamboo, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the Order of the Green Polo) you are welcome to merge the PR.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

…ashboard but this feature no longer exists in Grafana v9

Migrated changes from HELM-415, HELM-416, and HEM-418 to 9.x branch, as they had been merged into develop in error.
@Bonrob2 Bonrob2 requested a review from synqotik June 28, 2023 15:04
@github-actions github-actions bot added the docs label Jun 28, 2023
@Bonrob2 Bonrob2 changed the base branch from develop to release-9.x June 28, 2023 15:04
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Bonrob2 Bonrob2 merged commit cef25e6 into release-9.x Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants