HELM-446: Convert Perf datasource NaN values to nulls #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synqotik
requested review from
scthompsonopen,
RangerRick,
mmahacek and
christianpape
mmahacek
previously approved these changes
Jun 29, 2023
thanks! have to fix a Sonar issue, so may need re-approval... |
synqotik
force-pushed
the
jira/HELM-446-perf-convert-nan-to-null
branch
from
b951982
to
633fa5e
Compare
synqotik
force-pushed
the
jira/HELM-446-perf-convert-nan-to-null
branch
from
633fa5e
to
c5d0ffc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Refactored |
mmahacek
approved these changes
Jun 29, 2023
|
Noted a few variables that could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert any 'NaN' values received by the Performance data source to nulls. This was done in v8 of this plugin.
Was causing issues with for example the Stat Grafana visualization panel using the Calculation "Last *", which displays the last non-null value, however it would consider
"NaN"to be a valid value and display it instead of a valid numeric value.Flows has the
nanToZerofeature which may be more appropriate for flows data.External References