BE: NMS-16536, Provisioning fails when category has been deleted

[smunir-onms]

• https://opennms.atlassian.net/browse/NMS-16536

[cgorantla]

Were you able to reproduce this issue on foundation-2023 without any changes to the code ?

[smunir-onms]

Screencast from 10-17-2024 01:42:44 AM.webm
Unit test validation screen-recording attached

[cgorantla]

Check if you can add a test case for this in ProvisionerIT using actual Daos instead of mocks.

[cgorantla]

Please resolve file permissions 100644 → 100755.

and try to add a test case to validate the scenario with actual Daos

[christianpape]

LGTM.

[smunir-onms]

The last three asserts should also be passed for a complete scenario, there are some IT DAO limitations;

When m_provisionService.updateNodeAttributes(n); is called from the test class

the last category with ID 3 was deleted

the related association was also deleted

new category created with the same name with new ID 4

new association, with the same node and new category, going to be created

after this action, the category was updated with the previous ID 3 in the association

the category dao was also updated with a duplicate category with old ID 3

Due to this behavior, the last three asserts failed.

[cgorantla]

@smunir-onms can you merge latest foundation-2023 in this branch

[smunir-onms]

@smunir-onms can you merge latest foundation-2023 in this branch

Done.