- 
                Notifications
    
You must be signed in to change notification settings  - Fork 416
 
Integrate Clang AddressSanitizer in tests #1903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
39b44c1    to
    efc5ee8      
    Compare
  
    5659d05    to
    0efd96b      
    Compare
  
    | - name: Test ASAN | ||
| if: matrix.backend == 'asan' | ||
| run: | | ||
| ASAN_OPTIONS=detect_leaks=1:print_stats=1 tests/ctranslate2_test tests/data | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force ASAN_OPTIONS=detect_leaks=1 in case os: [ubuntu-22.04] matrix expands in the future (leak detection is turned on by default on Linux).
| matrix: | ||
| os: [ubuntu-22.04] | ||
| backend: [mkl, dnnl] | ||
| backend: [mkl, dnnl, asan] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also be in an independent  job instead of build-and-test-cpp-x86_64.
| 
           For context:  | 
    
          
 Thanks for the note. Worth noting that sanitisers still exist but are maintained under the LLVM project (link).   | 
    
5b85a40    to
    43743ae      
    Compare
  
    
Temporarily introduced a memory leak in an operator to check that
asanworks:https://github.com/OpenNMT/CTranslate2/actions/runs/16419223767/job/46392885237#logs