-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F OpenNebula/one#6430: Replace Sunstone screenshots #2906
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d1982e
F OpenNebula/docs#6430 Replaced Sunstone w/FireEdge images in Backup …
pedroielpi3 367ed8b
F OpenNebula/docs#6430 Replaced Sunstone w/FireEdge images in Backup …
pedroielpi3 1fa7425
F OpenNebula/docs#6430 Replaced Sunstone w/FireEdge images in Backup …
pedroielpi3 47e17f0
F OpenNebula/one#6430: Replace Sunstone screenshots
pedroielpi3 db8740e
F OpenNebula/one#6430: Replace Sunstone screenshots
pedroielpi3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd rather use the resulting dialog after pressing add action, it's more telling than just an empty sched actions subtab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed that's more informative. My only doubt is that some readers may not understand how to reach the "Schedule action" dialog box, since the image would not show the "Add Action" button which produces that dialog. If needed I can make a slight modification in the doc text to reflect this, or create a composite image that includes a mouse pointer on the "Add Action" button and the resulting dialog box. For now I've only added the image with the dialog box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see, i think modifying the text to reflect the need to press that Add Action is the most elegant way to solve this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agreed. Modified the doc. For the button descriptions I used the same letter case as in the FireEdge UI (that's why it says "Add action" instead of "Add Action")