B #3858: Update CPU model VM (#3895)

Signed-off-by: Jorge Lobo <jlobo@opennebula.systems>
OpenNebula · Oct 31, 2019 · 936df07 · 936df07
1 parent 1cd286d
commit 936df07
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 19 deletions.
diff --git a/src/sunstone/public/app/tabs/templates-tab/form-panels/create/wizard-tabs/os.js b/src/sunstone/public/app/tabs/templates-tab/form-panels/create/wizard-tabs/os.js
@@ -322,9 +322,15 @@ define(function(require) {
   function _retrieve(context) {
     var templateJSON = {};
     var osJSON = {};
-    $.extend(osJSON, WizardFields.retrieve(".bootTab", context));
-    $.extend(osJSON, WizardFields.retrieve(".kernelTab", context));
-    $.extend(osJSON, WizardFields.retrieve(".ramdiskTab", context));
+    $.extend(osJSON, WizardFields.retrieve(
+      $(".bootTab", context)
+    ));
+    $.extend(osJSON, WizardFields.retrieve(
+      $(".kernelTab", context)
+    ));
+    $.extend(osJSON, WizardFields.retrieve(
+      $(".ramdiskTab", context)
+    ));
 
     var boot = _retrieveBootValue(context);
 
@@ -334,13 +340,24 @@ define(function(require) {
       osJSON["BOOT"] = "";
     }
 
-    if (!$.isEmptyObject(osJSON)) { templateJSON["OS"] = osJSON; };
+    if (!$.isEmptyObject(osJSON)) {
+      templateJSON["OS"] = osJSON; 
+    }
+
+    var featuresJSON = WizardFields.retrieve(
+      $(".featuresTab", context)
+    );
+    if (!$.isEmptyObject(featuresJSON)) { 
+      templateJSON["FEATURES"] = featuresJSON; 
+    }
 
-    var featuresJSON = WizardFields.retrieve(".featuresTab", context);
-    if (!$.isEmptyObject(featuresJSON)) { templateJSON["FEATURES"] = featuresJSON; };
+    var cpuModelJSON = WizardFields.retrieve(
+      $(".cpuTab", context)
+    );
 
-    var cpuModelJSON = WizardFields.retrieve(".cpuTab", context);
-    if (!$.isEmptyObject(cpuModelJSON)) { templateJSON["CPU_MODEL"] = cpuModelJSON; };
+    if (!$.isEmptyObject(cpuModelJSON)) { 
+      templateJSON["CPU_MODEL"] = cpuModelJSON; 
+    }
 
     return templateJSON;
   }

diff --git a/src/sunstone/public/app/tabs/vms-tab/form-panels/updateconf.js b/src/sunstone/public/app/tabs/vms-tab/form-panels/updateconf.js
@@ -127,12 +127,18 @@ define(function(require) {
     });
   }
 
-  function _submitWizard(context) {
-    var templateJSON = {}
+  function _submitWizard() {
+    var context = ".sunstone-content > #vms-tab #vms-tab-wizardForms.is-active";
+    var templateJSON = {};
     $.each(this.wizardTabs, function(index, wizardTab) {
-      $.extend(true, templateJSON, wizardTab.retrieve($('#' + wizardTab.wizardTabId, context)));
+      $.extend(
+        true, 
+        templateJSON, 
+        wizardTab.retrieve(
+          $('#' + wizardTab.wizardTabId, context)
+        )
+      );
     });
-
     Sunstone.runAction("VM.updateconf", this.resourceId, TemplateUtils.templateToString(templateJSON));
     return false;
 

diff --git a/src/sunstone/public/app/utils/wizard-fields.js b/src/sunstone/public/app/utils/wizard-fields.js
@@ -35,21 +35,20 @@ define(function(require) {
 
     fields.each(function() {
       var field = $(this);
-
-      if (field.prop('wizard_field_disabled') != true &&
-            field.val() != null && field.val().length &&
-            (field.attr("type") != "checkbox" || field.prop("checked")) &&
-            (field.attr("type") != "radio" || field.prop("checked"))) {
+      if(
+        field.prop('wizard_field_disabled') != true &&
+        field.val() != null && field.val().length &&
+        (field.attr("type") != "checkbox" || field.prop("checked")) &&
+        (field.attr("type") != "radio" || field.prop("checked"))
+      ) {
         var field_name = field.attr('wizard_field');
-
         if (field.attr('wizard_field_64') == "true"){
           templateJSON[field_name] = btoa(field.val());
         } else {
           templateJSON[field_name] = _retrieveInput(field);
         }
       }
     });
-
     return templateJSON;
   }