Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines removed from template parameters #2515

Closed
7 tasks
vholer opened this issue Oct 17, 2018 · 2 comments
Closed
7 tasks

Newlines removed from template parameters #2515

vholer opened this issue Oct 17, 2018 · 2 comments

Comments

@vholer
Copy link
Contributor

vholer commented Oct 17, 2018

Description
Newlines are removed from all template parameters, which breaks their content.

To Reproduce

Following simple use-cases:

  1. user with SSH_PUBLIC_KEY could have multiple SSH keys inside, now all are merged into a single line

  2. VM template could have START_SCRIPT in the context section with a plain shell script; now again all lines are merged into single line

image

image

image

Expected behavior
A clear and concise description of what you expected to happen.

Details

  • Affected Component: Core
  • Version: 5.6.3

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@vholer
Copy link
Contributor Author

vholer commented Oct 17, 2018

Observations:

  1. content with preserved newlines is stored into the database
  2. on object read from database, the newlines are stripped and this broken content is presented to the user
  3. if user modifies the broken content, it's persisted in the database

@feldsam
Copy link
Contributor

feldsam commented Feb 26, 2019

This problem is also when saving multiple ssh keys to user profile. It is saved ok, but when you try edit, everything is in one line and you have to fix it before saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants