Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LXD drivers fail to unmap non rootfs devices if deploy fails #3098

Closed
7 tasks
dann1 opened this issue Mar 19, 2019 · 0 comments
Closed
7 tasks

LXD drivers fail to unmap non rootfs devices if deploy fails #3098

dann1 opened this issue Mar 19, 2019 · 0 comments

Comments

@dann1
Copy link
Contributor

dann1 commented Mar 19, 2019

Description
As seen in the forum in several entries LXD drivers fail to deploy containers because the context disk was detected already mounted prior to the process of setting up the container storage. This condition occurs when, for any reason, the container fails to start and the error handling code fails to detect the device corresponding to the container context mountpoint.

To Reproduce
The idea is to create a container that fails to start and then trying to start it again.

For example, taking advantege of #3058

  • Create a container with an ovs nic
  • poweroff the contaner
  • start the container (this will fail and leave the context mounted)
  • delete-recreate or retry (this will fail when detecting context already mounted)

Expected behavior
LXD drivers should revert all of the storage actions (maps and mounts) when a start fails for whatever reason

Details

  • Affected Component: Virtualization Drivers
  • Hypervisor: LXD
  • Version: 5.8.0

Additional context
When LXD attempts to start a container with declared disks in it devices section it changes the mountpoint of block devices, ex. a context device mapping with the container running is /var/lib/lxd/devices/one-14/disk.context.context

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@dann1 dann1 self-assigned this Mar 19, 2019
@dann1 dann1 added this to the Release 5.8.1 milestone Mar 19, 2019
dann1 added a commit to dann1/one that referenced this issue Mar 20, 2019
dann1 added a commit to dann1/one that referenced this issue Mar 20, 2019
dann1 added a commit to dann1/one that referenced this issue Mar 20, 2019
dann1 added a commit to dann1/one that referenced this issue Mar 20, 2019
@dann1 dann1 closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant