Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision template extends multiple templates #3237

Closed
7 tasks
vholer opened this issue Apr 16, 2019 · 3 comments
Closed
7 tasks

Provision template extends multiple templates #3237

vholer opened this issue Apr 16, 2019 · 3 comments
Assignees
@al3xhh
Labels
Category: Provision Status: Accepted Type: Feature
Milestone
Release 5.12

Comments

@vholer
Copy link
Contributor

vholer commented Apr 16, 2019

Description
We already support chaining of several provision templates with the extends: parameter. This parameter can contain only reference to a single template. It would be useful to support a list of multiple templates to extend from and recursively evaluate them in the order they are written. For example:

---
extends:
  - template1.yaml
  - template2.yaml
  - template3.yaml
  - template4.yaml
...

Use case
Provide a separate templates for virtual networks and datastores, and be able to include both of them from a single template.

Progress Status

  • Branch created
  • Code committed to development branch
  • Testing - QA
  • Documentation
  • Release notes - resolved issues, compatibility, known issues
  • Code committed to upstream release/hotfix branches
  • Documentation committed to upstream release/hotfix branches
@vholer vholer added this to the Release 5.10 milestone Apr 16, 2019
@al3xhh al3xhh self-assigned this Apr 26, 2019
al3xhh pushed a commit to al3xhh/one that referenced this issue May 17, 2019
F OpenNebula#3237: provision template extends multiple templates
2670c36
@al3xhh
Copy link
Contributor

al3xhh commented May 17, 2019

PRs to merge in master:

Code: #3352
Docs: OpenNebula/docs#632

al3xhh pushed a commit to al3xhh/one that referenced this issue May 20, 2019
F OpenNebula#3237: provision template extends multiple templates
174d961
al3xhh pushed a commit to al3xhh/one that referenced this issue May 21, 2019
F OpenNebula#3237: provision template extends multiple templates
162cf12
@vholer
Copy link
Contributor Author

vholer commented Jul 9, 2019

Consider this Ruby gem to implement the extends in a clear and sane way:
https://www.rubydoc.info/gems/yaml_extend/0.2.5

@vholer vholer modified the milestones: Release 5.10, Release 5.10.1 Sep 5, 2019
@tinova tinova modified the milestones: Release 5.10.1, Release 5.10.2 Dec 11, 2019
@tinova tinova modified the milestones: Release 5.10.2, Release 5.10.3 Feb 12, 2020
al3xhh pushed a commit to al3xhh/one that referenced this issue Apr 1, 2020
F OpenNebula#3237: extend multiple templates
f92b6cf
al3xhh pushed a commit to al3xhh/one that referenced this issue Apr 6, 2020
F OpenNebula#3237: reverse order
67a750e
al3xhh pushed a commit to al3xhh/one that referenced this issue Apr 6, 2020
F OpenNebula#3237: reverse order
44c7761
@al3xhh
Copy link
Contributor

al3xhh commented Apr 6, 2020

PRs to merge in master:

rsmontero pushed a commit that referenced this issue Apr 8, 2020
F #3237: DDC extends multiple templates (#4470)
fdf8e5c
rsmontero pushed a commit to OpenNebula/docs that referenced this issue Apr 8, 2020
F OpenNebula/one#3237: add documentation (#1034)
57d2774
al3xhh pushed a commit to al3xhh/one that referenced this issue Apr 8, 2020
F OpenNebula#3237: DDC extends multiple templates
05aeca7
rsmontero pushed a commit that referenced this issue Apr 8, 2020
F #3237: DDC extends multiple templates (#4501)
3991267
@al3xhh al3xhh closed this as completed Apr 8, 2020
rsmontero pushed a commit that referenced this issue Oct 4, 2024
@paczerny
M #-: onedb fsck check history seqence id (#3237)
a3c4776 
* It looks like `onedb purge-history` sometimes fails to delete some history records.
* Delete all history records with SEQ greater then VM/HISTORY_RECORDS/HISTORY/SEQ, which should be the last record
rsmontero pushed a commit that referenced this issue Jan 13, 2025
@paczerny @rsmontero
M #-: onedb fsck check history seqence id (#3237)
48506a7 
* It looks like `onedb purge-history` sometimes fails to delete some history records.
* Delete all history records with SEQ greater then VM/HISTORY_RECORDS/HISTORY/SEQ, which should be the last record

(cherry picked from commit a3c4776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@al3xhh al3xhh

Labels
Category: Provision Status: Accepted Type: Feature
Projects
None yet
Milestone
Release 5.12
Development

No branches or pull requests
4 participants
@tinova @vholer @rsmontero @al3xhh