retry_if function may mask error (kvm and TM[ssh] drivers)

[xorel]

Description
When retry_if function is used to retry a call which runs exit on failure (such as exec_and_log), retry_if function reports the error but not exit on error.

This may lead to unexpected results, e.g. onevm suspend finished correctly although the checkpoint save failed

Thu Jan 5 02:23:59 2023 [Z0][VM][I]: New LCM state is SAVE_SUSPEND
Thu Jan 5 02:24:10 2023 [Z0][VMM][E]: save: Command "virsh --connect qemu:///system save 2af29c7a-9dba-44e2-89e9-89c29b2c72b0 /var/lib/one//datastores/102/1927/checkpoint" failed: error: Failed to save domain '2af29c7a-9dba-44e2-89e9-89c29b2c72b0' to /var/lib/one//datastores/102/1927/checkpoint error: operation failed: domain is not running Could not save 2af29c7a-9dba-44e2-89e9-89c29b2c72b0 to /var/lib/one//datastores/102/1927/checkpoint
Thu Jan 5 02:24:10 2023 [Z0][VMM][I]: ExitCode: 0

To Reproduce
Simulate saving checkpoint error in the drivers, run onevm save, check logs.

Expected behavior
retry_if function needs to act exactly the same as the original call

Details

• Affected Component: storage drivers, KVM drivers
• 6.2+ (and possibly older)

Progress Status

• Code committed
• Testing - QA
• Documentation (Release notes - resolved issues, compatibility, known issues)