Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireedge is not showing Datastore limit on system datastore and is not showing right limit on images datastore #6746

Closed
3 tasks
Franco-Sparrow opened this issue Oct 8, 2024 · 4 comments · Fixed by OpenNebula/docs#3073
Assignees

Comments

@Franco-Sparrow
Copy link

Franco-Sparrow commented Oct 8, 2024

Description

Fireedge (FSunstone) is not properly showing datastore limit. For system datastore limit is not shown and for images datastore is not showing the right value. The limit is working, as is on the CLI output for the datastores. Old Sunstone also shows the right limit on both datastores. The problem is on FSunstone.

Working on CLI for system datastore:

WhatsApp Image 2024-10-07 at 7 05 01 PM

Working on CLI for images datastore:

WhatsApp Image 2024-10-07 at 7 06 28 PM

Working on OLD Sunstone for system datastore:

WhatsApp Image 2024-10-07 at 7 14 46 PM

Working on OLD Sunstone for images datastore:

WhatsApp Image 2024-10-07 at 7 14 55 PM

NOT working on FSunstone for system datastore:

WhatsApp Image 2024-10-07 at 7 07 46 PM

NOT working on FSunstone for images datastore:

WhatsApp Image 2024-10-07 at 7 08 50 PM

To Reproduce

Configure LIMIT_MB datastore attribute on system and images datastores. Update those datastores with this attribute.

Expected behavior

FSunstone showing the right datastore limite on both datastores.

Details

  • Affected Component: [FSunstone]
  • Hypervisor: [KVM]
  • Version: [6.10.0]

Additional context
Add any other context about the problem here.

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@Franco-Sparrow
Copy link
Author

Hi @vichansson

I have you another FSunstone issue. Just a cosmetic one. Sorry to call directly on this, but as you assisted my previous FSunstone issue, I wanted to let you know this bug on first hand.

Cheers

@vichansson
Copy link
Contributor

Hi @Franco-Sparrow !

Thanks for the heads up. I just tried this myself and FSunstone does indeed round up the DS limit pretty aggressively. Added a fix to 6.10.1 where the number precision is increased to one decimal place, which should replicate the behavior of RSunstone.

Best regards,
Victor

@vichansson vichansson self-assigned this Oct 8, 2024
vichansson added a commit to OpenNebula/docs that referenced this issue Oct 8, 2024
Signed-off-by: Victor Hansson <vhansson@opennebula.io>
@vichansson vichansson linked a pull request Oct 8, 2024 that will close this issue
2 tasks
@Franco-Sparrow
Copy link
Author

Hi @vichansson

Did you also checked the limit on the systemdatastore? In this case is omitted by Sunstone, while is aggressively roundup on the images datastores, as you can witness.

Thanks for you quick support.

tinova pushed a commit to OpenNebula/docs that referenced this issue Oct 8, 2024
Signed-off-by: Victor Hansson <vhansson@opennebula.io>
@vichansson
Copy link
Contributor

Hi @Franco-Sparrow ,

Yes, the limit should be displayed on all kinds of datastores. The only issue I could find with the limit not being displayed properly on system datastores was if the Filesystem - shared mode storage backend was being used. This adds the SHARED property which FSunstone used to dynamically render the limit. This check has however been removed from 6.10.1.

Cheers,
Victor

@tinova tinova closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants