Fix LXD not handling nic removal from openvswitch bridges #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applies to master as well |
rsmontero
reviewed
Mar 22, 2019
rsmontero
reviewed
Mar 22, 2019
| @@ -177,6 +177,11 @@ def start(options = {}) | |||
|
|
|||
| def stop(options = { :timeout => 120 }) | |||
| change_state(__method__, options) | |||
|
|
|||
There was a problem hiding this comment.
This should be called through the pre/post/clean scripts. This code should be moved to the owsirch network drivers
rsmontero
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike libvirt which handles the ports removal on nic detach action nad powerofss, LXD just handles nic port creation on start and nic attach. The drivers have been updated to remove ports on unhandled actions if nic matches ovswitch driver.
Fixes #3058