Fix ext4 issues with uuidgen #3110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dann1
commented
Mar 21, 2019
| @@ -512,15 +510,37 @@ def reset_fs_uuid(fs_type, device) | |||
| when /xfs/ | |||
| cmd = "#{COMMANDS[:xfs_admin]} -U generate #{device}" | |||
| when /ext/ | |||
| cmd = "#{COMMANDS[:tune2fs]} tune2fs -U random #{device}" | |||
There was a problem hiding this comment.
this was the main issue, the command was 2 times written
dann1
commented
Mar 21, 2019
| _rc, o, e = Command.execute("#{COMMANDS[:e2fsck]} -f -y #{device}", false) | ||
| err = "#{__method__}: failed to resize #{device}\n" | ||
|
|
||
| _rc, o, e = check_ext4(device) |
There was a problem hiding this comment.
after poweroff they failed to boot again when recreating the fs uuid, it required e2fsck to be run again
|
Applies to 5.8 as well. Seems 6883f6a wasn't merged in the previous PR. There are other minor improvements as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext4 single partition images were failing