Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F #2505: Allow detach disks for VM with snapshots #3187

Merged
merged 1 commit into from
Apr 9, 2019
Merged

F #2505: Allow detach disks for VM with snapshots #3187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/vmm_mad/remotes/lib/vcenter_driver/virtual_machine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2012,17 +2012,18 @@ def detach_disk(disk)
begin
@item.ReconfigVM_Task(:spec => spec_hash).wait_for_completion
rescue Exception => e
raise "Cannot detach DISK from VM: #{e.message}\n#{e.backtrace}"
raise "Cannot detach DISK from VM: #{e.message}\n#{e.backtrace}"\
"Probably an existing VM snapshot includes that disk"
end
end

def destroy_disk(disk)
one_vm = one_item

detachable= !(one_vm["LCM_STATE"].to_i == 11 && !disk.managed?)
detachable = detachable && !has_snapshots? && disk.exists?
detachable = detachable && disk.exists?

return unless detachable
raise "Can not detach disk. Not supported on current configuration" unless detachable

detach_disk(disk)
disk.destroy()
Expand Down