-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resources update methods #95
Comments
Some providers seems to remove Calling From my understanding, a diff may be applied to the state, even in case of an error during update operation, for values that aren't For instance VM context should be impacted (or some other attributes only used at VM creation time), but to me, it seems to be an other problem, we should just read it or forbid the user to update it with a check. The PR I proposed for now remove all |
Update methods doesn't work all the same way there is some refactoring to do.
Some of them use
Partial
andSetPartial
methods, some others not.As a side note,
SetPartial
is deprecated in later version of terraform SDK (but we don't use the SDK for now): https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#removal-of-helper-schema-resourcedata-setpartialSome of them don't call the read method at the end of the update.
I modified the VM update method in a previous PR (NIC update) but I still have some points to figure out around partial update of the state in case of update failure
The text was updated successfully, but these errors were encountered: