B #169: fix VM update template #171
Conversation
treywelsh
changed the title
treywelsh
force-pushed
the
B-169-fix-vm-config-update
branch
2 times, most recently
from
42cd775
to
f2d42ca
Compare
| tpl := vm.NewTemplate() | ||
| for _, name := range []string{"OS", "FEATURES", "INPUT", "GRAPHICS", "RAW", "CONTEXT"} { |
There was a problem hiding this comment.
why in the following lines you work only on "OS", "GRAPHICS" and "CONTEXT".
Why not "FEATURES", "INPUT" or "RAW" ?
There was a problem hiding this comment.
I copy these sections only, from the existing VM template, because the method updateconf take them into account:
https://docs.opennebula.io/5.12/integration/system_interfaces/api.html#one-vm-updateconf
If I don't copy one of these fields, it would be erased. See OS deletion problem when updating CONTEXT in #169 .
The RAW field is managed through the template resource, I didn't enabled it in VM resource, here is the original issue about this section: #123
Do we need it in VM resource ?
For other parts FEATURES and INPUT there aren't managed at all.
This is not the goal of this issue, but to manage additional VM sections we could open a new issue (probably better) or just add them to #154
treywelsh
force-pushed
the
B-169-fix-vm-config-update
branch
from
f2d42ca
to
00cc3ae
Compare
|
Thanks guys for your great work ! 👏 👍 |
PR #145 enabled VM config update with some bad behavior due to a misunderstanding of the ONE API.