Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-359: manage template vectors #362

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

treywelsh
Copy link
Collaborator

@treywelsh treywelsh commented Oct 12, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Until now, it's possible to pass custom (key=value) pairs to an OpenNebula resource via the provider.
However it doesn't allow to pass a custom vector (keyvec = [key=value, ... ] ).
The goal of this issue is to allow to pass custom vectors to resources.

Limitation: for simplicity it will be only possible to manage a vector with a unique name

References

Close #359

New or Affected Resource(s)

  • opennebula_group
    TODO: all other resources

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@treywelsh treywelsh changed the title WIP manage template sections F-359: manage template vectors Oct 12, 2022
@frousselet frousselet changed the base branch from master to 1.1.0 October 22, 2022 11:33
@treywelsh treywelsh force-pushed the F-359-manage-template-vectors branch 4 times, most recently from 23e6bf2 to 17aff2f Compare October 26, 2022 13:35
@treywelsh treywelsh force-pushed the F-359-manage-template-vectors branch from 17aff2f to acfb888 Compare November 9, 2022 16:43
@treywelsh treywelsh marked this pull request as ready for review November 10, 2022 12:55
@treywelsh treywelsh force-pushed the F-359-manage-template-vectors branch 5 times, most recently from dbeae5e to b475924 Compare November 14, 2022 15:18
@treywelsh treywelsh marked this pull request as draft November 14, 2022 15:19
@treywelsh treywelsh force-pushed the F-359-manage-template-vectors branch 2 times, most recently from 997c617 to 996e5c3 Compare November 14, 2022 17:30
@treywelsh
Copy link
Collaborator Author

I had to fix an SDK bug in the provider due to: hashicorp/terraform-plugin-sdk#588
The acceptance test were failing due to an empty template_section returned by the SDK. I filtered out this empty item.

@treywelsh treywelsh marked this pull request as ready for review November 14, 2022 21:41
Copy link
Collaborator

@frousselet frousselet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen, tags should be named elements.

Base automatically changed from 1.1.0 to master November 17, 2022 16:04
@frousselet frousselet marked this pull request as draft November 17, 2022 16:09
@treywelsh treywelsh force-pushed the F-359-manage-template-vectors branch 2 times, most recently from fbf9cfa to 8635f40 Compare November 17, 2022 16:32
@treywelsh treywelsh marked this pull request as ready for review November 17, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opennebula_group: Add template_section attribute for custom template sections
2 participants