Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B-552: Fix compatible_system_datastore parsing #576

Merged
merged 1 commit into from
Oct 21, 2024
Merged

B-552: Fix compatible_system_datastore parsing #576

merged 1 commit into from
Oct 21, 2024

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented Oct 18, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

References

#552

New or Affected Resource(s)

  • opennebula_datastore

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

@rsmontero rsmontero added this to the 1.4.1 milestone Oct 21, 2024
dgarcia18
dgarcia18 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@dgarcia18 dgarcia18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + manually tested

@dgarcia18 dgarcia18 merged commit 51e0840 into master Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarcia18 dgarcia18 dgarcia18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sk4zuzu @dgarcia18 @rsmontero