chore(lint): Linting and error handling fixes

packages/openneuro-components/src/search-page/CommunityHeader.tsx

@@ -3,7 +3,7 @@ import React from "react"
 export interface CommunityHeaderProps {
   communityHeader: string
   communityPrimary: string
-  communitySecondary: Record<string, any>
+  communitySecondary: Record<string, object>
 }
 
 export const CommunityHeader = ({

packages/openneuro-components/src/search-page/SearchResultsList.tsx

@@ -6,9 +6,9 @@ import "./search-page.scss"
 
 export interface SearchResultsListProps {
   items
-  profile?: Record<string, any>
+  profile?: Record<string, object>
   datasetTypeSelected: string
-  hasEditPermissions: (permissions: any, userId: any) => boolean
+  hasEditPermissions: (permissions: object, userId: string) => boolean
 }
 export const SearchResultsList = ({
   items,

packages/openneuro-components/src/tooltip/Tooltip.tsx

@@ -1,4 +1,5 @@
-import React, { FC } from "react"
+import React from "react"
+import type { FC } from "react"
 
 export interface TooltipProps {
   tooltip: string

packages/openneuro-indexer/src/indexDatasets.ts

@@ -25,6 +25,7 @@ export default async function indexDatasets(
     }
     await aliasDatasetsIndex(elasticClient)
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error(e)
   }
 }

packages/openneuro-server/src/cache/item.ts

@@ -13,7 +13,7 @@ const decompress = promisify(zlib.gunzip)
  */
 export function cacheKey(
   type: CacheType,
-  compositeKeys: Array<string>,
+  compositeKeys: string[],
 ): string {
   return `${type.toString()}:${compositeKeys.join(":")}`
 }
@@ -35,7 +35,7 @@ class CacheItem {
   constructor(
     redis: Redis,
     type: CacheType,
-    compositeKeys?: Array<string>,
+    compositeKeys?: string[],
     expiration?: number,
   ) {
     this.redis = redis

packages/openneuro-server/src/datalad/snapshots.ts

@@ -1,6 +1,7 @@
 /**
  * Get snapshots from datalad-service tags
  */
+import * as Sentry from "@sentry/node"
 import request from "superagent"
 import { reindexDataset } from "../elasticsearch/reindex-dataset"
 import { redis, redlock } from "../libs/redis"
@@ -16,7 +17,8 @@ import { getFiles } from "./files"
 import { generateDataladCookie } from "../libs/authentication/jwt"
 import notifications from "../libs/notifications"
 import Dataset from "../models/dataset"
-import Snapshot, { SnapshotDocument } from "../models/snapshot"
+import Snapshot from "../models/snapshot"
+import type { SnapshotDocument } from "../models/snapshot"
 import { updateDatasetRevision } from "./draft"
 import { getDatasetWorker } from "../libs/datalad-service"
 import { join } from "path"
@@ -62,6 +64,8 @@ const createIfNotExistsDoi = async (
         descriptionFieldUpdates["DatasetDOI"] = `doi:${snapshotDoi}`
       }
     } catch (err) {
+      Sentry.captureException(err)
+      // eslint-disable-next-line no-console
       console.error(err)
       throw new Error("DOI minting failed.")
     }

packages/openneuro-server/src/elasticsearch/reindex-dataset.ts

@@ -1,12 +1,8 @@
 import config from "../config"
 import { indexDataset, indexingToken, queryForIndex } from "@openneuro/search"
 import { elasticClient } from "./elastic-client"
-import {
-  ApolloClient,
-  from,
-  InMemoryCache,
-  NormalizedCacheObject,
-} from "@apollo/client"
+import { ApolloClient, from, InMemoryCache } from "@apollo/client"
+import type { NormalizedCacheObject } from "@apollo/client"
 import { setContext } from "@apollo/client/link/context"
 import { HttpLink } from "@apollo/client/link/http"
 

packages/openneuro-server/src/graphql/resolvers/dataset.ts

@@ -125,6 +125,7 @@ export const deleteDataset = async (
     await removeDatasetSearchDocument(id)
   } catch (err) {
     // This likely means this dataset had not yet been indexed
+    /* eslint-disable-next-line no-console */
     console.error(err)
   }
   await new Deletion({

packages/openneuro-server/src/graphql/resolvers/derivatives.ts

@@ -76,14 +76,14 @@ export const derivativeObject = (
  */
 export const derivatives = async (
   dataset: DatasetOrSnapshot,
-): Promise<Array<DatasetDerivatives>> => {
+): Promise<DatasetDerivatives[]> => {
   let datasetId
   if ("tag" in dataset) {
     datasetId = getDatasetFromSnapshotId(dataset.id)
   } else {
     datasetId = dataset.id
   }
-  const available: Array<DatasetDerivatives> = []
+  const available: DatasetDerivatives[] = []
   if (await githubDerivative(datasetId, "mriqc")) {
     available.push(derivativeObject(datasetId, "mriqc"))
   }

packages/openneuro-server/src/graphql/resolvers/draft.ts

@@ -3,7 +3,7 @@ import { summary } from "./summary"
 import { issues } from "./issues.js"
 import { description } from "./description.js"
 import { readme } from "./readme.js"
-import { getDraftRevision, updateDatasetRevision } from "../../datalad/draft.js"
+import { getDraftRevision } from "../../datalad/draft.js"
 import { checkDatasetWrite } from "../permissions.js"
 import { getFiles } from "../../datalad/files"
 import { filterRemovedAnnexObjects } from "../utils/file.js"

packages/openneuro-server/src/graphql/resolvers/reviewer.ts

@@ -37,7 +37,7 @@ export async function deleteReviewer(
 /**
  * Resolver for dataset reviewers
  */
+/* eslint-disable-next-line @typescript-eslint/no-unused-vars */
 export function reviewers(obj, _, { user, userInfo }) {
-  /* eslint-disable-line @typescript-eslint/no-unused-vars */
   return Reviewer.find({ datasetId: obj.id }).lean().exec()
 }