chore(lint): Remaining eslint refactor fixes

packages/openneuro-app/src/scripts/authentication/profile.ts

@@ -1,6 +1,6 @@
 import jwtDecode from "jwt-decode"
 
-interface OpenNeuroTokenProfile {
+export interface OpenNeuroTokenProfile {
   sub: string
   email: string
   provider: string

packages/openneuro-app/src/scripts/common/containers/__tests__/header.spec.tsx

@@ -10,7 +10,6 @@ vi.mock("../../../uploader/uploader-view.jsx", () => ({
   default: () => "mocked UploaderView",
 }))
 vi.mock("react-router-dom", async () => ({
-  // @ts-ignore-check
   ...(await vi.importActual("react-router-dom")),
   useNavigate: () => navigate,
 }))

packages/openneuro-app/src/scripts/common/content/terms.tsx

@@ -1,7 +1,7 @@
-import React, { ReactElement } from "react"
+import React from "react"
 
 /** Terms and conditions content. */
-export function Terms(): ReactElement {
+export function Terms(): React.ReactElement {
   return (
     <>
       <p>

packages/openneuro-app/src/scripts/components/data-table.tsx

@@ -4,13 +4,14 @@ import {
   flexRender,
   getCoreRowModel,
   getSortedRowModel,
-  SortingState,
   useReactTable,
 } from "@tanstack/react-table"
+import type { SortingState } from "@tanstack/react-table"
 import styled from "@emotion/styled"
 import { format, isValid, parse } from "date-fns"
 
 interface DataTableProps {
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   data: any[]
   downloadFilename?: string
   hideColumns?: string[]
@@ -55,6 +56,7 @@ export function extractDateString(dateString) {
   return false
 }
 
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
 function CellFormat(props): any {
   const value = props.getValue()
   let extractedDate
@@ -86,6 +88,7 @@ export function DataTable<T>({
       Object.keys(data[0])
         .filter((name) => !hideColumns.includes(name))
         .map((name) =>
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           columnHelper.accessor(name as any, {
             header: name,
             cell: CellFormat,

packages/openneuro-app/src/scripts/datalad/mutations/snapshot.tsx

@@ -33,7 +33,7 @@ const CreateSnapshotMutation = ({ datasetId, tag, changes }) => {
 interface SnapshotDatasetProps {
   datasetId: string
   tag: string
-  changes: Array<string>
+  changes: string[]
 }
 
 const SnapshotDataset = ({ datasetId, tag, changes }: SnapshotDatasetProps) => (

packages/openneuro-app/src/scripts/dataset/comments/comment-editor.jsx

@@ -20,7 +20,7 @@ const CommentEditor = ({
   )
   const doAfterSubmit = () => {
     setEditorState(EditorState.createEmpty())
-    done && done()
+    if (done) done()
   }
   const disabled = editorState.getUndoStack().size === 0
   return (

packages/openneuro-app/src/scripts/dataset/components/DatasetToolButton.tsx

@@ -1,5 +1,6 @@
 import React from "react"
-import styled, { StyledComponent } from "@emotion/styled"
+import styled from "@emotion/styled"
+import type { StyledComponent } from "@emotion/styled"
 import { Link } from "react-router-dom"
 import { Tooltip } from "@openneuro/components/tooltip"
 import { Icon } from "@openneuro/components/icon"

packages/openneuro-app/src/scripts/dataset/components/DatasetTools.tsx

@@ -1,11 +1,11 @@
 import React from "react"
 import { DatasetToolButton } from "./DatasetToolButton"
-import styled, { StyledComponent } from "@emotion/styled"
+import styled from "@emotion/styled"
+import type { StyledComponent } from "@emotion/styled"
 import { useAgreement } from "../../components/agreement"
 
-interface DatasetToolStyleProps {}
-
-export const DatasetToolStyle: StyledComponent<DatasetToolStyleProps> = styled
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
+export const DatasetToolStyle: StyledComponent<{}> = styled
   .span`
   display: flex;
   justify-content: flex-start;

packages/openneuro-app/src/scripts/dataset/files/file-tree.tsx

@@ -17,6 +17,7 @@ interface FileTreeProps {
   files: DatasetFile[]
   editMode: boolean
   defaultExpanded: boolean
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   datasetPermissions: any
   toggleFileToDelete: ({ id, path, filename }) => void
   isFileToBeDeleted: (id: string) => boolean

packages/openneuro-app/src/scripts/dataset/files/files.tsx

@@ -39,7 +39,9 @@ interface FilesProps {
   datasetName: string
   files: DatasetFile[]
   editMode: boolean
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   datasetPermissions: any
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   summary: any
 }
 

packages/openneuro-app/src/scripts/dataset/files/viewers/file-viewer-nifti.tsx

@@ -17,17 +17,19 @@ const FileViewerNifti = ({
         limitFrames4D: 5,
       },
     ]
-    const nv = new Niivue({ dragAndDropEnabled: false })
+    const nv = new Niivue({
+      dragAndDropEnabled: false,
+    }) /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
     ;(window as any).niivue = nv
     nv.attachToCanvas(canvas.current)
     nv.loadVolumes(volumeList) // press the "v" key to cycle through views (axial, coronal, sagittal, 3D, etc.)
     nv.graph.autoSizeMultiplanar = true // use autosizing
     nv.opts.multiplanarForceRender = true // ensure that we draw the time series graph in the tile usually reserved for the 3D render
     nv.graph.normalizeValues = false // use raw data values on y-axis
     nv.graph.opacity = 1.0 // show the graph
-    // Notes: 
+    // Notes:
     // 1.   If an image only has one volume, the timeseries graph will not be visible.
-    //      The 3D render will be placed in the graph tile instead. 
+    //      The 3D render will be placed in the graph tile instead.
     // 2.   Users can navigate volumes forward and backward in the series using the left and right arrow keys on desktop devices
     // 3.   On touch screens, users can tap on the timeseries graph to jump to a volume index
     // 4.   Users can load all volumes by clicking on the "..." displayed on the timeseries graph

packages/openneuro-app/src/scripts/dataset/fragments/__tests__/select-input.spec.tsx

@@ -74,7 +74,6 @@ describe("SelectInput", () => {
     )
     const event = {
       preventDefault() {
-        null
       },
       target: { value: "false" },
     }

packages/openneuro-app/src/scripts/dataset/fragments/copyable-tooltip.jsx

@@ -1,3 +1,4 @@
+import * as Sentry from "@sentry/react"
 import React from "react"
 import PropTypes from "prop-types"
 import styled from "@emotion/styled"
@@ -44,12 +45,9 @@ function fallbackCopyTextToClipboard(text) {
   textArea.select()
 
   try {
-    const success = document.execCommand("copy")
-    console.log(
-      `Copying text command was ${success ? "successful!" : "unsuccessful."}`,
-    )
+    document.execCommand("copy")
   } catch (err) {
-    console.error("Could not copy text: ", err)
+    Sentry.captureException(err)
   }
 
   document.body.removeChild(textArea)
@@ -59,8 +57,8 @@ function copyTextToClipboard(text) {
   if (!navigator.clipboard) fallbackCopyTextToClipboard(text)
   else {
     navigator.clipboard.writeText(text).then(
-      () => console.log("Copying to clipboard was successful!"),
-      (err) => console.error("Could not copy text: ", err),
+      () => {},
+      (err) => Sentry.captureException(err),
     )
   }
 }

packages/openneuro-app/src/scripts/dataset/mutations/create-anonymous-reviewer.tsx

@@ -1,7 +1,6 @@
 import React from "react"
 import type { FC } from "react"
 import { gql, useMutation } from "@apollo/client"
-import { Link } from "react-router-dom"
 import { Tooltip } from "@openneuro/components/tooltip"
 import { Button } from "@openneuro/components/button"
 

packages/openneuro-app/src/scripts/dataset/mutations/delete-anonymous-reviewer.tsx

@@ -13,6 +13,12 @@ const DELETE_REVIEWER = gql`
   }
 `
 
+// TODO - derive from GraphQL
+interface ReviewerUser {
+  id: string
+  email: string
+}
+
 interface DeleteReviewerLinkProps {
   datasetId: string
   id: string
@@ -27,7 +33,7 @@ export const DeleteReviewerLink: FC<DeleteReviewerLinkProps> = ({
 }) => {
   const [DeleteReviewerLink] = useMutation(DELETE_REVIEWER, {
     update(cache, { data: { deleteReviewer } }) {
-      const { reviewers } = cache.readFragment<{ reviewers: any[] }>({
+      const { reviewers } = cache.readFragment<{ reviewers: ReviewerUser[] }>({
         id: `Dataset:${datasetId}`,
         fragment: DATASET_REVIEWERS,
       })

packages/openneuro-app/src/scripts/dataset/mutations/import-dataset.tsx

@@ -1,4 +1,4 @@
-import React, { FC, useState } from "react"
+import React, { useState } from "react"
 import { gql, useApolloClient, useMutation } from "@apollo/client"
 import { Button } from "@openneuro/components/button"
 import { createDataset } from "../../uploader/upload-mutation"
@@ -25,7 +25,7 @@ interface ImportDatasetMutationProps {
   disabled?: boolean | null
 }
 
-export const ImportDatasetMutation: FC<ImportDatasetMutationProps> = ({
+export const ImportDatasetMutation: React.FC<ImportDatasetMutationProps> = ({
   url,
   disabled,
   affirmedDefaced,

packages/openneuro-app/src/scripts/dataset/mutations/snapshot.tsx

@@ -20,7 +20,7 @@ const CREATE_SNAPSHOT = gql`
 interface CreateSnapshotMutationProps {
   datasetId: string
   tag: string
-  changes: Array<string>
+  changes: string[]
   disabled: boolean
 }
 
@@ -47,8 +47,7 @@ const CreateSnapshotMutation = ({
         onClick={(): void => {
           void snapshotDataset({
             variables: { datasetId, tag, changes },
-          }).then((data) => {
-            console.log(data)
+          }).then((_data) => {
             navigate(`/datasets/${datasetId}/versions/${tag}`)
           })
         }}
@@ -62,7 +61,7 @@ const CreateSnapshotMutation = ({
 interface SnapshotDatasetProps {
   datasetId: string
   tag: string
-  changes: Array<string>
+  changes: string[]
   disabled: boolean
 }
 

packages/openneuro-app/src/scripts/dataset/routes/add-metadata.jsx

@@ -25,7 +25,7 @@ const runValidations = (values) =>
     .map((validation) => {
       const relevantValues = validation.fields.map((key) => values[key])
       // TODO - This doesn't seem necessary?
-      // @ts-expect-error
+      // @ts-expect-error this is a size 2 tuple but not checked due to jsx instead of tsx
       const isValid = validation.check(relevantValues)
       if (!isValid) return validation.errorMessage
     })
@@ -52,7 +52,7 @@ const AddMetadata = ({ dataset }) => {
     const errors = runValidations(newValues)
     if (hasChanged(errors, validationErrors)) setValidationErrors(errors)
   }
-  // @ts-ignore-next-line
+  // @ts-expect-error location.state is not fully typed
   const submitPath = location.state && location.state.submitPath
   const user = getProfile(cookies)
   const hasEdit = (user && user.admin) ||

packages/openneuro-app/src/scripts/dataset/routes/delete-page.tsx

@@ -11,7 +11,7 @@ import { HeaderRow3 } from "./styles/header-row"
 
 interface DeletePageProps {
   dataset: {
-    permissions: Record<string, any>
+    permissions: Record<string, object>
     id: string
   }
 }

packages/openneuro-app/src/scripts/dataset/routes/snapshot.tsx

@@ -1,5 +1,6 @@
 import React, { useState } from "react"
-import semver, { ReleaseType } from "semver"
+import semver from "semver"
+import type { ReleaseType } from "semver"
 import SnapshotDataset from "../mutations/snapshot"
 import EditList from "../fragments/edit-list.jsx"
 import { Button } from "@openneuro/components/button"

packages/openneuro-app/src/scripts/errors/errorBoundary.jsx

@@ -74,7 +74,7 @@ ErrorBoundary.propTypes = {
 
 // specific use case
 // ignore error in apollo lib
-// @ts-expect-error
+// @ts-expect-error TODO - this is incorrectly extended but working
 class ErrorBoundaryAssertionFailureException extends ErrorBoundary {
   constructor(props) {
     super(props)
@@ -104,7 +104,6 @@ class ErrorBoundaryDeletePageException extends ErrorBoundary {
         const throwError = !/^\/datasets\/ds\d{6}\/delete$/.test(
           window.location.pathname,
         )
-        console.log(throwError)
         return throwError
       },
     )

packages/openneuro-app/src/scripts/search/inputs/modality-select.tsx

@@ -2,7 +2,8 @@ import React, { useContext } from "react"
 import type { FC } from "react"
 import { useNavigate } from "react-router-dom"
 import { SearchParamsCtx } from "../search-params-ctx"
-import { flattenedModalities, SearchParams } from "../initial-search-params"
+import { flattenedModalities } from "../initial-search-params"
+import type { SearchParams } from "../initial-search-params"
 import { FacetSelect } from "@openneuro/components/facets"
 import { AccordionTab, AccordionWrap } from "@openneuro/components/accordion"
 import initialSearchParams from "../initial-search-params"

packages/openneuro-app/src/scripts/search/inputs/sort-by-select.tsx

@@ -4,6 +4,7 @@ import { SearchParamsCtx } from "../search-params-ctx"
 import { SearchSort } from "@openneuro/components/search-page"
 
 interface SortBySelectProps {
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   variables: any
 }
 

packages/openneuro-app/src/scripts/search/search-container.tsx

@@ -45,6 +45,7 @@ import Helmet from "react-helmet"
 import AdminUser from "../authentication/admin-user.jsx"
 
 export interface SearchContainerProps {
+  /* eslint-disable-next-line @typescript-eslint/no-explicit-any */
   portalContent?: Record<string, any>
 }
 
@@ -53,7 +54,9 @@ export interface SearchContainerProps {
  */
 export const setDefaultSearch = (
   modality: string,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   searchParams: Record<string, any>,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   setSearchParams: (newParams: Record<string, any>) => void,
   query: URLSearchParams,
 ): void => {

packages/openneuro-app/src/scripts/search/search-params-ctx.tsx

@@ -1,14 +1,16 @@
-import React, { createContext, FC, ReactNode, useContext } from "react"
+import * as Sentry from "@sentry/react"
+import React, { createContext, useContext } from "react"
 import { useSearchParams } from "react-router-dom"
-import initialSearchParams, { SearchParams } from "./initial-search-params"
+import initialSearchParams from "./initial-search-params"
+import type { SearchParams } from "./initial-search-params"
 
 export const SearchParamsCtx = createContext(null)
 
 interface SearchParamsProviderProps {
-  children: ReactNode
+  children: React.ReactNode
 }
 
-export const SearchParamsProvider: FC<SearchParamsProviderProps> = ({
+export const SearchParamsProvider: React.FC<SearchParamsProviderProps> = ({
   children,
 }) => {
   const [searchQuery, setSearch] = useSearchParams()
@@ -20,7 +22,7 @@ export const SearchParamsProvider: FC<SearchParamsProviderProps> = ({
       searchParams = JSON.parse(query)
     }
   } catch (err) {
-    console.error(err)
+    Sentry.captureException(err)
   }
 
   const setSearchParams = (

packages/openneuro-app/src/scripts/sw.ts

@@ -5,6 +5,7 @@
  */
 export default null
 declare const self: ServiceWorkerGlobalScope
+/* eslint-disable-next-line @typescript-eslint/no-explicit-any */
 const globalAny: any = global // Workaround for serviceWorkerOption type missing
 const CACHE_NAME = "openneuro"
 const CACHE_PATHS = globalAny.serviceWorkerOption.assets

packages/openneuro-app/src/scripts/users/username.tsx

@@ -8,7 +8,6 @@ import { config } from "../config"
 export const Username = ({ user }): JSX.Element => {
   if (user.orcid) {
     let orcidURL = "https://orcid.org/"
-    console.log(config.auth.orcid)
     if (config.auth.orcid.ORCID_API_ENDPOINT.includes("sandbox")) {
       orcidURL = "https://sandbox.orcid.org/"
     }

packages/openneuro-app/src/scripts/utils/gtag.js

@@ -1,8 +1,8 @@
 /*global globalThis*/
 globalThis.dataLayer = globalThis.dataLayer || []
 
-function gtag() {
-  globalThis.dataLayer.push(arguments)
+function gtag(...args) {
+  globalThis.dataLayer.push(args)
 }
 
 gtag("js", new Date())