Add missing structure definitions, fix existing. #213

Backporter · 2022-10-13T05:36:16Z

Adds *OrbisNpTrophyScreenshotTarget, *OrbisNpTrophyGroupData, *OrbisNpTrophyGroupDetails, *OrbisNpTrophyGameData, *OrbisNpTrophyGameDetails

adds *OrbisNpTrophyScreenshotTarget, *OrbisNpTrophyGroupData, *OrbisNpTrophyGroupDetails, *OrbisNpTrophyGameData, *OrbisNpTrophyGameDetails

add comments back.

…Toolchain

savedata stuff **can** be removed if needed, through it should have a correct size now.

fix type.

include/orbis/_types/save_data.h

added required structures and fixed existing function definitions,

- fixed all but five defs, - swapped over to OrbisRtcDateTime from TimeTable - swapped over to OrbisRtcTick from RealTick

removes the default definitions and puts them inside a enum

illusion0001 · 2023-07-08T12:04:43Z

Needs rebase

Backporter · 2023-07-09T23:40:08Z

yes

Backporter · 2023-08-03T02:59:39Z

lets hope that was enough...

fix type....

....

add missing OrbisSystemServiceGpuLoadEmulationMode def

...

kiwidoggie · 2023-08-04T13:28:21Z

include/orbis/Rtc.h

+int32_t sceRtcTickAddTicks(OrbisRtcDateTime *inputOrbisRtcDateTime, OrbisRtcTick *inputTick, int64_t ticks);
+int32_t sceRtcTickAddWeeks(OrbisRtcDateTime *inputOrbisRtcDateTime, OrbisRtcTick *inputTick, int32_t weeks);
+int32_t sceRtcTickAddYears(OrbisRtcDateTime *inputOrbisRtcDateTime, OrbisRtcTick *inputTick, int32_t years);
+int32_t sceRtcConvertLocalTimeToUtc(OrbisRtcTick*, OrbisRtcTick*);


Function calls needs names, if you don't know what it is, call it unknown0 or something similar

kiwidoggie · 2023-08-04T13:28:58Z

include/orbis/NpTrophy.h

-// Empty Comment
-void sceNpTrophyGetTrophyUnlockState();
-// Empty Comment
+int32_t sceNpTrophyAbortHandle(int32_t a_handle);


should be just handle not a_ prefix

kiwidoggie · 2023-08-04T13:29:49Z

include/orbis/SystemService.h

 int32_t sceSystemServiceHideSplashScreen(void);
 int32_t sceSystemServiceParamGetInt(int32_t paramId, int32_t *value);
 int32_t sceSystemServiceParamGetString(int32_t paramId, char *buf, size_t bufSize);
 int32_t sceSystemServiceGetAppIdOfBigApp(void);
 int32_t sceSystemServiceGetAppIdOfMiniApp(void);
-int32_t sceLncUtilLaunchApp(const char* title_id, const char* argv[], LncAppParam* param);


was this intended to be removed?

kiwidoggie · 2023-08-04T13:30:28Z

include/orbis/SystemService.h

+int32_t sceSystemServiceEnablePersonalEyeToEyeDistanceSetting();
+int32_t sceSystemServiceDisablePersonalEyeToEyeDistanceSetting();
+int32_t sceSystemServiceShowEyeToEyeDistanceSetting();
+int32_t sceSystemServiceIsEyeToEyeDistanceAdjusted(int32_t, bool*);


arguments need names, if unsure mark them as unknown0 or similar

kiwidoggie · 2023-08-04T13:31:02Z

include/orbis/SystemService.h

 int32_t sceSystemServiceHideSplashScreen(void);
 int32_t sceSystemServiceParamGetInt(int32_t paramId, int32_t *value);
 int32_t sceSystemServiceParamGetString(int32_t paramId, char *buf, size_t bufSize);
 int32_t sceSystemServiceGetAppIdOfBigApp(void);
 int32_t sceSystemServiceGetAppIdOfMiniApp(void);
-int32_t sceLncUtilLaunchApp(const char* title_id, const char* argv[], LncAppParam* param);
-int32_t sceSystemServiceKillApp(uint32_t appid, int32_t opt, int32_t method, int32_t reason);
+int32_t sceSystemServiceKillApp(uint32_t appid, int opt, int method, int reason);


this is inconsistent, revert this change back to int32_t

kiwidoggie · 2023-08-04T13:33:50Z

include/orbis/_types/Np.h

+	uint32_t unlockedSilver;
+	uint32_t unlockedBronze;
+	uint32_t progressPercentage;
+	uint8_t UNK00[4];


use lowerCamcelCase here

kiwidoggie · 2023-08-04T13:34:22Z

include/orbis/_types/Videodec.h

+#pragma once
+#include <stdint.h>
+
+#define ORBIS_VIDEODEC_ERROR_API_FAIL				        -2134835200	// = 0x80C10000


Should this be an enum?

kiwidoggie · 2023-08-04T13:36:29Z

include/orbis/_types/kernel.h

 	uintptr_t	ident;		/* identifier for this event */
-	short		filter;	/* filter for event */
+	short		  filter;	/* filter for event */


don't think this was intentional

kiwidoggie · 2023-08-04T13:37:57Z

include/orbis/_types/pad.h

 #define ORBIS_PAD_CONNECTION_TYPE_STANDARD 0
 #define ORBIS_PAD_CONNECTION_TYPE_REMOTE   2

-enum OrbisPadButton
+typedef enum OrbisPadButtonDataOffset : uint32_t


Verify that this does not break C support/samples.

kiwidoggie · 2023-08-04T13:39:43Z

include/orbis/_types/sys_service.h

+{
+	OrbisSystemServiceEventType	eventType;
+	union 
+  {


formatting needs fixing

kiwidoggie · 2023-08-09T15:21:00Z

include/orbis/Videodec.h

-int32_t sceVideodecQueryResourceInfo(const OrbisVideodecConfigInfo*, OrbisVideodecResourceInfo*);
-int32_t sceVideodecReset(OrbisVideodecCtrl*);
-int32_t sceVideodecDeleteDecoder(OrbisVideodecCtrl*);
+int32_t sceVideodecCreateDecoder(const OrbisVideodecConfigInfo* CfgInfoIn, const OrbisVideodecResourceInfo* RsrcInfoIn, OrbisVideodecCtrl* CtrlOut);


lowerCamelCase

kiwidoggie · 2023-08-09T15:21:15Z

include/orbis/Videodec2.h

-int32_t sceVideodec2ReleaseComputeQueue(void*);
-int32_t sceVideodec2Reset(void*);
-int32_t sceVideodec2DeleteDecoder(void*);
+int32_t sceVideodec2AllocateComputeQueue(const OrbisVideodec2ComputeConfigInfo* ComputeCfgInfoIn, const OrbisVideodec2ComputeMemoryInfo* ComputeMemInfoIn, void** ComputeQueueOut);


lowerCamelCase

…Toolchain

Backporter added 6 commits October 13, 2022 01:33

Add Missing NpTrophy structure definitions.

eff2931

adds *OrbisNpTrophyScreenshotTarget, *OrbisNpTrophyGroupData, *OrbisNpTrophyGroupDetails, *OrbisNpTrophyGameData, *OrbisNpTrophyGameDetails

Merge branch 'OpenOrbis:master' into master

d51f3c8

Update Np.h

00e7e5e

add comments back.

Merge branch 'master' of https://github.com/Backporter/OpenOrbis-PS4-…

aa43955

…Toolchain

0

4b44a3f

savedata stuff **can** be removed if needed, through it should have a correct size now.

Update kernel.h

0d2dc6c

fix type.

Backporter changed the title ~~Add Missing NpTrophy structure definitions.~~ Add missing structure definitions, fix existing. Nov 12, 2022

bucanero reviewed Nov 14, 2022

View reviewed changes

include/orbis/_types/save_data.h Show resolved Hide resolved

Backporter added 6 commits December 10, 2022 21:30

add VideoDecX structures and fix function definitions

4d2ed72

added required structures and fixed existing function definitions,

Update Rtc.h

8df6a34

- fixed all but five defs, - swapped over to OrbisRtcDateTime from TimeTable - swapped over to OrbisRtcTick from RealTick

Merge branch 'master' into master

24897c3

Update Rtc.h

0dff13c

move controller keycodes into a enum

fb3f088

removes the default definitions and puts them inside a enum

Merge branch 'master' into master

7047d4b

Merge branch 'master' into master

82ee4b7

Backporter added 6 commits August 2, 2023 23:05

Update Rtc.h

4424cd9

fix type....

Update Rtc.h

a70028f

....

Update Rtc.h

0b6555f

Update sys_service.h

03b1d82

add missing OrbisSystemServiceGpuLoadEmulationMode def

Update sys_service.h

3984d83

...

Update sys_service.h

5153a13

kiwidoggie requested changes Aug 4, 2023

View reviewed changes

Backporter added 3 commits August 6, 2023 01:48

fix formatting, add/fix param names

366cc0f

Update Rtc.h

f88be88

Update Rtc.h

edef451

kiwidoggie reviewed Aug 9, 2023

View reviewed changes

Create Mouse.h

b9ffada

Backporter added 2 commits August 25, 2023 13:12

Update Mouse.h

cee9e9a

Merge branch 'master' of https://github.com/Backporter/OpenOrbis-PS4-…

9b9e82a

…Toolchain

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing structure definitions, fix existing. #213

Add missing structure definitions, fix existing. #213

Backporter commented Oct 13, 2022

illusion0001 commented Jul 8, 2023

Backporter commented Jul 9, 2023

Backporter commented Aug 3, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 4, 2023

kiwidoggie Aug 9, 2023

kiwidoggie Aug 9, 2023

Add missing structure definitions, fix existing. #213

Are you sure you want to change the base?

Add missing structure definitions, fix existing. #213

Conversation

Backporter commented Oct 13, 2022

illusion0001 commented Jul 8, 2023

Backporter commented Jul 9, 2023

Backporter commented Aug 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment