Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GnmDriver: Add definitions for SetEmbeddedShader and DrawIndexAuto #240

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

pipehuffer
Copy link

Also added comments describing the required number of DWORDs used by commands.

@pipehuffer pipehuffer force-pushed the master branch 2 times, most recently from ba9c827 to 8ccc6cd Compare May 28, 2023 23:37
@pipehuffer
Copy link
Author

Did a small change to this: there's now a definition for sceGnmDrawIndirect and OrbisGnmDrawIndexFlags was renamed to OrbisGnmDrawFlags since it's used by the former

@kiwidoggie
Copy link
Contributor

I was comparing these arguments against GPCS4, seems to have different arguments there, have you checked that the arguments are correct?

@pipehuffer
Copy link
Author

seems to have different arguments there

From a quick glance I found SetEmbeddedPsShader to be different, since it's missing the last argument in GPCS4 (I assume it's because it wasn't reversed by its author yet).
The flags argument is also different, being named pred from predicate. While OrbisGnmDrawFlags does indeed have a predicate field, it also has rendertargetsliceoffset which is supposed to be filled by the caller, although I haven't found anything using it so far in a base PS4.

I'll take this opportunity to add some more definitions to this patch and give its commit a more generic description.

@pipehuffer
Copy link
Author

pipehuffer commented Aug 19, 2023

kiwidoggie reacted with thumbs up emoji

Sorry, didn't mean to say that I was working on more changes for this patch. It should be good to be merged as it is.

@kiwidoggie kiwidoggie merged commit c552039 into OpenOrbis:master Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants