Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in Symbol Editor's Combination settings #1600

Closed
dl3sdo opened this issue May 3, 2020 · 3 comments · Fixed by #1605
Closed

Crash in Symbol Editor's Combination settings #1600

dl3sdo opened this issue May 3, 2020 · 3 comments · Fixed by #1605
Assignees
@dg0yt
Labels
known issues v0.9.2
Milestone
v0.9.3

Comments

@dl3sdo
Copy link
Member

dl3sdo commented May 3, 2020

Steps to reproduce

  1. Edit a symbol consisting of combined symbols, e.g. 501.0 Motorway
  2. In 'Combination settings' increase Number of parts from 2 to 4 or to 5
  3. For Symbol 4 or 5 choose any symbol (for private line or area symbol: just cancel it)
  4. Press Reset button => Mapper always crashes

Actual behaviour

Mapper always crashes

Configuration

Mapper Version: v20200411.3 or v0.92
Operating System: Win7x64
@dg0yt dg0yt self-assigned this May 10, 2020
@dg0yt dg0yt added this to the v0.9.3 milestone May 10, 2020
@dg0yt
Copy link
Member

dg0yt commented May 10, 2020

Extra step required to reproduce the crash:

  1. Click 'Cancel'

@dl3sdo
Copy link
Member Author

dl3sdo commented May 10, 2020

Of course, sorry, I forgot to mention the 'Cancel' operation.

@dg0yt
Copy link
Member

dg0yt commented May 10, 2020

Well, memory corruption happens on 'Reset' indeed... my setup just doesn't crash before 'Cancel'.

dg0yt added a commit that referenced this issue May 10, 2020
@dg0yt
CombinedSymbolSettings: Block signals on symbol reset
e10f7eb 
When the number of subsymbols decreases, we must block signal
emissions while resetting obsolete symbol edits.
Fixes GH-1600 (Crash when editing combined symbols).
@dg0yt dg0yt mentioned this issue May 10, 2020
Merged
dg0yt added a commit that referenced this issue May 10, 2020
@dg0yt
CombinedSymbolSettings: Block signals on symbol reset
3879b35 
When the number of subsymbols decreases, we must block signal
emissions while resetting obsolete symbol edits.
Fixes GH-1600 (Crash when editing combined symbols).
@dg0yt dg0yt mentioned this issue May 12, 2020
Merged
dg0yt added a commit that referenced this issue May 13, 2020
@dg0yt
CombinedSymbolSettings: Block signals on symbol reset
287d553 
When the number of subsymbols decreases, we must block signal
emissions while resetting obsolete symbol edits.
Fixes GH-1600 (Crash when editing combined symbols).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dg0yt dg0yt

Labels
known issues v0.9.2
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging a pull request may close this issue.

CombinedSymbolSettings: Block signals on symbol reset OpenOrienteering/mapper
2 participants
@dg0yt @dl3sdo