Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add scribble template #1830

Closed
lpechacek opened this issue Dec 29, 2020 · 2 comments · Fixed by #1832
Closed

Cannot add scribble template #1830

lpechacek opened this issue Dec 29, 2020 · 2 comments · Fixed by #1832
Labels
bug

Comments

@lpechacek
Copy link
Member

Affects the pre-release build. v0.9.4 is fine.

Steps to reproduce

  1. Open a georeferenced map.
  2. Tap-and-hold Paint on template button.
  3. Select Add template.

Actual behaviour

Mapper says that it cannot open the new scribble template.

Expected behaviour

In v0.9.4 the template gets added and opened.

Configuration

Mapper Version: master v20201227.4
Operating System: Android and openSUSE Tumbleweed
@lpechacek lpechacek added the bug label Dec 29, 2020
@dg0yt
Copy link
Member

dg0yt commented Dec 29, 2020

Confirmed.

@dg0yt
Copy link
Member

dg0yt commented Dec 29, 2020

Reproducible on the desktop.

dg0yt added a commit that referenced this issue Dec 29, 2020
@dg0yt
PaintOnTemplateFeature: Fix setupTemplate()
53fa24a 
Indicate that template configuration is finished before loading the
template file, so that that function takes care of setting the state
to Loaded on success.
Complements aee1057.
Fixes GH-1830 (Cannot add scribble template).
@dg0yt dg0yt mentioned this issue Dec 29, 2020
Merged
dg0yt added a commit that referenced this issue Dec 29, 2020
@dg0yt
PaintOnTemplateFeature: Fix setupTemplate()
7f7060a 
Explicitly signal that the template configuration is complete by
setting template state 'Unloaded' before attempting to load the
template file. This is a prerequisite for 'Template::loadTemplateFile'
to update the state to 'Loaded' on success.
Complements aee1057.
Fixes GH-1830 (Cannot add scribble template).
dg0yt added a commit that referenced this issue Dec 29, 2020
@dg0yt
PaintOnTemplateFeature: Fix setupTemplate()
2d5c8eb 
Explicitly signal that the template configuration is complete by
setting template state 'Unloaded' before attempting to load the
template file. This is a prerequisite for 'Template::loadTemplateFile'
to update the state to 'Loaded' on success.
Complements aee1057.
Fixes GH-1830 (Cannot add scribble template).
@lpechacek lpechacek mentioned this issue Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PaintOnTemplateFeature: Fix setupTemplate() OpenOrienteering/mapper
2 participants
@lpechacek @dg0yt